Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH1831: Verify CurrentToken is not null before checking Kind property #1832

Conversation

jpreese
Copy link
Contributor

@jpreese jpreese commented Sep 25, 2017

For #1831

Discussed briefly in the CAKE gitter. This should be a better place for any discussions if they are needed.

@dnfclas
Copy link

dnfclas commented Sep 25, 2017

@jpreese,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla2.dotnetfoundation.org.

It will cover your contributions to all .NET Foundation-managed open source projects.
Thanks,
.NET Foundation Pull Request Bot

@dnfclas
Copy link

dnfclas commented Sep 25, 2017

@jpreese, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, .NET Foundation Pull Request Bot

@jpreese jpreese force-pushed the jpreese-fix/clean-directories-null-exception branch from 43d8fe3 to 1d5e719 Compare September 25, 2017 18:28
@jpreese jpreese force-pushed the jpreese-fix/clean-directories-null-exception branch from 1d5e719 to 29c5447 Compare September 25, 2017 18:34
@devlead devlead changed the title Verify CurrentToken is not null before checking Kind property GH1831: Verify CurrentToken is not null before checking Kind property Sep 26, 2017
Copy link
Member

@devlead devlead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@devlead devlead merged commit 29c5447 into cake-build:develop Sep 26, 2017
@devlead
Copy link
Member

devlead commented Sep 26, 2017

@jpreese your changes have been merged, thanks for your contribution 👍

@jpreese
Copy link
Contributor Author

jpreese commented Sep 26, 2017

Awesome! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants