GH2498: Preserves rooted path values in HintPath #2649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests updated. |
When parsing HintPath values, "rooted" path values will be preserved. Relative path values will still be "rooted" to current dir.
agc93
force-pushed
the
feature/GH-2498
branch
from
6553a9b to
52d6324
Compare
devlead
changed the title
|
Relates to: #2498 |
|
@agc93 your changes have been merged, thanks for your contribution 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When parsing HintPath values, "rooted" path values will be preserved as-is.
Relative path values will still be combined with current dir.
Tests have also been updated but to be honest, those tests could probably be cleaned up a bit.