Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dotnet sln and list commands #3817

Closed
wants to merge 1 commit into from

Conversation

megakid
Copy link

@megakid megakid commented Feb 17, 2022

This adds some additional commands for inspection and manipulation of solution and csproj files using the dotnet SDK CLI.

@dnfadmin
Copy link

dnfadmin commented Feb 17, 2022

CLA assistant check
All CLA requirements met.

@megakid megakid force-pushed the dotnet-list-and-sln branch from 8a7302f to 4fc2ee3 Compare February 17, 2022 11:26
@pascalberger pascalberger requested a review from gep13 March 6, 2022 20:59
@gep13
Copy link
Member

gep13 commented Mar 6, 2022

@megakid are you in a position to look at the failing CI builds, and to figure out what the issues with them are?

In addition, we discussed this internally, and we feel that this PR would be broken into two, one for the sln command, and one for the list command. That will make it much easier to review and provide feedback. In addition, as per the contributing guidelines, can you please create issues for this functionality that you would like to add? Thanks!

@Marusyk
Copy link
Contributor

Marusyk commented Oct 10, 2023

if there is no response from the author, let's create 2 issues (one for the sln command, and one for the list command) and I will try to prepare PRs
@gep13

@DmitryLukyanov
Copy link

I would love to see this merged, do you have any updates here?

@devlead devlead force-pushed the dotnet-list-and-sln branch from b3c6f92 to 57d7cb7 Compare October 31, 2024 11:57
@devlead
Copy link
Member

devlead commented Oct 31, 2024

I would love to see this merged, do you have any updates here?

@DmitryLukyanov This PR currently waiting for issuer feedback as there are still some issues and missing tests with the proposed code that will need to be corrected before it can be merged.

In Cake 4.1 added dotnet list reference and list package with

So there's some overlap here already available in Cake, that also needs to be taken into account.

Unsure if @megakid has the cycles/opportunity to do so, if not we're open to reviewing alternative PRs.

@Marusyk
Copy link
Contributor

Marusyk commented Nov 14, 2024

Hi @DmitryLukyanov,
sln add and sln list are already available in Cake v5.0.0
sln remove will be added in the next version (PR is here)

@devlead I suppose this PR can be closed

@devlead
Copy link
Member

devlead commented Nov 15, 2024

@devlead I suppose this PR can be closed

Yes.

@megakid thanks for your contribution 👍

@devlead devlead closed this Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants