Closes #486: CopyFile logs incorrect targetFilePath #487
Conversation
|
Looks sold @jrnail23 👍 , could you get the branch up to date and I'll merge. |
jrnail23
force-pushed
the
fix-copyfile-logging
branch
from
b7b5f62 to
3ed4531
Compare
|
@devlead, should be ready to go now, pending CI build |
|
Restarted Linux build that had timed out when restoring NuGet packages. |
|
@patriksvensson, did it happen again? |
|
@jrnail23 Hmm. Yes 😢 I'll restart it again. I should really try to get the packages properly cached on Travis since this fail in more than 50% of the builds. |
| var fixture = new FileCopyFixture(); | ||
|
|
||
| // When | ||
| FileAliases.CopyFile(fixture.Context, "./file1.txt", "./target/file1.txt"); |
There was a problem hiding this comment.
Sorry for nitpicking, but a better test would be to test for ./file1.txt and ./target/file2.txt.
If I understand correctly the bug will output the filename of the target file first, which would give the same results.
There was a problem hiding this comment.
I agree, but the fixture isn't very straightforward in terms of changing that part. I did, however, start from a failing test.
I can still try to get that to work if you like.
There was a problem hiding this comment.
Ah, I see. I think it's OK then 😄
|
This looks good to me 👍 |
|
@jrnail23 Looks like this needs to be rebased against develop. |
jrnail23
force-pushed
the
fix-copyfile-logging
branch
from
3ed4531 to
94ca297
Compare
|
@patriksvensson, rebased again, ready to go (pending CI build) |
Closes #486: CopyFile logs incorrect targetFilePath
|
Merged @jrnail23, thanks for contributing 👍 |
|
👍 |
No description provided.