Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GH-762) Fix TeamCity Disposable #763

Merged

Conversation

RichiCoder1
Copy link
Contributor

Currently TeamCityDisposableExtensions extends TeamCityProvider and
therefore aren't accessible by default. Switched to extend
ITeamCityProvider. Also now returns IDisposable.

@gep13
Copy link
Member

gep13 commented Mar 16, 2016

Relates to #762

@devlead
Copy link
Member

devlead commented Mar 17, 2016

@RichiCoder1 could you rebase this against latest develop and then I'll look at reviewing this for merging.

Currently TeamCityDisposableExtensions extends TeamCityProvider and
therefore aren't accessible by default. Switched to extend
ITeamCityProvider. Also now returns IDisposable.
@RichiCoder1 RichiCoder1 force-pushed the feature/GH-762_Fix_TeamCity_Disposable branch from ff63464 to dac7bbf Compare March 18, 2016 15:30
devlead added a commit that referenced this pull request Mar 18, 2016
@devlead devlead merged commit 93f7eda into cake-build:develop Mar 18, 2016
@devlead
Copy link
Member

devlead commented Mar 18, 2016

@RichiCoder1 merged, thanks for your contribution 👍

@RichiCoder1 RichiCoder1 deleted the feature/GH-762_Fix_TeamCity_Disposable branch May 1, 2016 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants