-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor(reCAPTCHA): remove icons #2564
Conversation
@thekaveman On #2537, it's noted that we should deploy all the changes out together:
What should merging these PRs look like? Merge into // cc @machikoyasuda |
@angela-tran Hmmm, I was thinking of the first option, but the second probably makes more sense just in case we need to release something before this is all ready. |
i.e. remove icon block and "media-line" div from base template. also remove now unused CSS style.
remove unneeded template whose sole purpose was to define the icon
e7735c0
to
a79563f
Compare
The second option sounds better to me too. |
benefits/eligibility/templates/eligibility/includes/media-item--bankcardcheck--start.html
Outdated
Show resolved
Hide resolved
@thekaveman @machikoyasuda Got it, thanks! I created edit: I created a branch protection rule for it too, copying settings for the one for |
nitpick: this is more than just copy right? |
It is. My thought was all these changes are stemming from us deciding to use our own reCAPTCHA copy instead of the badge, but I'm open to using a different branch name. Do you have one in mind? |
height: var(--media-item-icon-size); | ||
margin-right: var(--media-item-icon-margin); | ||
} | ||
|
||
.media-list-icon-left-margin { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming this class media-list-icon-left-margin
will be deleted in this ticket, #2569, and then we can delete all (or most) of these:
:root {
--media-item-icon-size: calc(64rem / 16);
--media-item-gap: calc(24rem / 16);
--media-item-icon-margin: calc(24rem / 16);
}
@media (min-width: 992px) {
:root {
--media-item-icon-size: calc(90rem / 16);
--media-item-gap: calc(24rem / 16);
--media-item-icon-margin: calc(32rem / 16);
}
}
Closes #2538
This PR removes the
bankcard
andidcardcheck
icons and removes them from the Eligibility Start and Enrollment Index pages.Screenshots of this branch