fix: fix email exclusion validation for full emails and and @-prefixed domains

[anikdhabal]

Summary by cubic

Updated booking email validation to correctly handle exact email exclusions and "@-prefixed" domains. The same logic is applied to required emails for consistency.

• Bug Fixes
  • Support three formats in exclude/require lists: "@domain.com", "user@domain.com", "domain.com".
  • Case-insensitive matching for emails and domains.
  • Added tests for full email exclusion and "@Domain" handling.

^{Written for commit 26552df. Summary will update on new commits.}

[cubic-dev-ai]

2 issues found across 2 files

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="packages/features/bookings/lib/getBookingResponsesSchema.ts">

<violation number="1" location="packages/features/bookings/lib/getBookingResponsesSchema.ts:213">
P2: Domain matching is case-sensitive while full email matching is case-insensitive. This inconsistency will cause domain exclusions/requirements to fail when the case differs (e.g., '@GMAIL.COM' won't match 'user@gmail.com'). Email domains are case-insensitive per RFC 5321.</violation>

<violation number="2" location="packages/features/bookings/lib/getBookingResponsesSchema.ts:235">
P2: Same case-sensitivity inconsistency in required emails validation. Domain matching should also be case-insensitive for consistency and RFC compliance.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[github-actions]

Devin AI is addressing Cubic AI's review feedback

A Devin session has been created to address the issues identified by Cubic AI.

View Devin Session

[cubic-dev-ai]

1 issue found across 1 file (changes from recent commits).

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="packages/features/bookings/lib/getBookingResponsesSchema.ts">

<violation number="1" location="packages/features/bookings/lib/getBookingResponsesSchema.ts:36">
P2: Domain matching is case-sensitive while full email matching is case-insensitive. This inconsistency may cause unexpected behavior when users enter domains in different cases. Consider normalizing both `bookerEmail` and `entry` to lowercase for domain comparisons.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[github-actions]

Devin AI is addressing Cubic AI's review feedback

A Devin session has been created to address the issues identified by Cubic AI.

View Devin Session

[hariombalhara]

LGTM !!

Though I find it a bit weird to match john@example.com, if I just specify example.com.

[pedroccastro]

Looks good!! 👍