Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: run proxy tests with a single worker instance #979

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix: run proxy tests with a single worker instance #979

wants to merge 4 commits into from
+44 −32

Conversation

xilosada
Copy link
Member

  • Introdued a single shared Worker instance across all tests to avoid conflicts caused by reusing ports.

miraclx
miraclx reviewed Nov 21, 2024
View reviewed changes
Copy link
Member

@miraclx miraclx left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one case where #[rstest] could come in handy, but best not to overcomplicate it, this is okay!

contracts/proxy-lib/tests/common/mod.rs Outdated Show resolved Hide resolved
@xilosada xilosada force-pushed the xilosada/fix-near-flaky-tests branch from 257d9d7 to bf9e9b4 Compare November 27, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miraclx miraclx miraclx left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xilosada @miraclx