From 7838ea61e965d7ae561b883ecca594558889276f Mon Sep 17 00:00:00 2001 From: Bartosz Klonowski <70535775+BartoszKlonowski@users.noreply.github.com> Date: Tue, 12 Oct 2021 10:25:28 +0200 Subject: [PATCH 1/3] Downgrade the compileSdkVersion to 29 - P --- example/android/build.gradle | 2 +- src/android/gradle.properties | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/example/android/build.gradle b/example/android/build.gradle index 4a1a8973..89eb2214 100644 --- a/example/android/build.gradle +++ b/example/android/build.gradle @@ -4,7 +4,7 @@ buildscript { ext { buildToolsVersion = "29.0.3" minSdkVersion = 21 - compileSdkVersion = 30 + compileSdkVersion = 29 targetSdkVersion = 29 } repositories { diff --git a/src/android/gradle.properties b/src/android/gradle.properties index 83b2ffa6..3d391894 100644 --- a/src/android/gradle.properties +++ b/src/android/gradle.properties @@ -1,4 +1,4 @@ -ReactNativeSlider_compileSdkVersion=30 +ReactNativeSlider_compileSdkVersion=29 ReactNativeSlider_buildToolsVersion=28.0.3 ReactNativeSlider_targetSdkVersion=27 ReactNativeSlider_minSdkVersion=16 \ No newline at end of file From 44781b5496f6259340ca6022287dd21cda9431c6 Mon Sep 17 00:00:00 2001 From: Bartosz Klonowski <70535775+BartoszKlonowski@users.noreply.github.com> Date: Tue, 12 Oct 2021 10:27:54 +0200 Subject: [PATCH 2/3] Check the Build.VERSION against bigger than Q instead of P --- .../com/reactnativecommunity/slider/ReactSliderManager.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/android/src/main/java/com/reactnativecommunity/slider/ReactSliderManager.java b/src/android/src/main/java/com/reactnativecommunity/slider/ReactSliderManager.java index 27fdeb66..df8ea62a 100644 --- a/src/android/src/main/java/com/reactnativecommunity/slider/ReactSliderManager.java +++ b/src/android/src/main/java/com/reactnativecommunity/slider/ReactSliderManager.java @@ -149,7 +149,7 @@ public void setValue(ReactSlider view, double value) { view.setOnSeekBarChangeListener(null); view.setValue(value); view.setOnSeekBarChangeListener(ON_CHANGE_LISTENER); - if (view.isAccessibilityFocused() && Build.VERSION.SDK_INT >= Build.VERSION_CODES.R) { + if (view.isAccessibilityFocused() && Build.VERSION.SDK_INT > Build.VERSION_CODES.Q) { int index = (int)value; view.setupAccessibility(index); } From cf5d2ec34dd6773ba9ee2fb831af27fe01e7381d Mon Sep 17 00:00:00 2001 From: Bartosz Klonowski <70535775+BartoszKlonowski@users.noreply.github.com> Date: Tue, 12 Oct 2021 16:42:55 +0200 Subject: [PATCH 3/3] Simplify the value passing to the accessibility launch --- .../com/reactnativecommunity/slider/ReactSliderManager.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/android/src/main/java/com/reactnativecommunity/slider/ReactSliderManager.java b/src/android/src/main/java/com/reactnativecommunity/slider/ReactSliderManager.java index df8ea62a..efd6ca37 100644 --- a/src/android/src/main/java/com/reactnativecommunity/slider/ReactSliderManager.java +++ b/src/android/src/main/java/com/reactnativecommunity/slider/ReactSliderManager.java @@ -150,8 +150,7 @@ public void setValue(ReactSlider view, double value) { view.setValue(value); view.setOnSeekBarChangeListener(ON_CHANGE_LISTENER); if (view.isAccessibilityFocused() && Build.VERSION.SDK_INT > Build.VERSION_CODES.Q) { - int index = (int)value; - view.setupAccessibility(index); + view.setupAccessibility((int)value); } }