Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache value is not valid when script is failed #770

Closed
hosseinmd opened this issue Oct 18, 2024 · 3 comments
Closed

Cache value is not valid when script is failed #770

hosseinmd opened this issue Oct 18, 2024 · 3 comments
Labels
status:new New issue, not reviewed by the team yet. type:bug A bug report.

Comments

@hosseinmd
Copy link
Contributor

hosseinmd commented Oct 18, 2024

Describe the bug

In some situation, for example network failed when loading a script, The failed script is cached.

System Info

repack 4.3.3
react-native 75.4

Re.Pack Version

4.3.3

Reproduction

https://github.com/callstack/repack

Steps to reproduce

Make your app fail to load remote script, then restart the app. Here the failed script doesn't download again, and it is trying to execute from cache, but there is no cache file.

@hosseinmd hosseinmd added status:new New issue, not reviewed by the team yet. type:bug A bug report. labels Oct 18, 2024
@jbroma
Copy link
Member

jbroma commented Oct 18, 2024

@hosseinmd, I'm finishing the work on MF2 and should release V5 RC very soon 🙏
I would put this issue on hold until we can verify that it's also happening on V5

@hosseinmd
Copy link
Contributor Author

Please review this #771
I made a good test scenario which can show you the problem

@jbroma
Copy link
Member

jbroma commented Oct 30, 2024

Thank you for handling this @hosseinmd!

Closing since this was fixed by #771.

Fix available in 5.0.0-rc.0 version of Re.Pack.

@jbroma jbroma closed this as completed Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:new New issue, not reviewed by the team yet. type:bug A bug report.
Projects
None yet
Development

No branches or pull requests

2 participants