fix: remove global since the problem was 2 XHRInterceptor instance

Author: dprevost-LMI

packages/network-activity-plugin/src/react-native/http/network-inspector.ts

@@ -14,10 +14,9 @@ import {
 
 const networkRequestsRegistry = getNetworkRequestsRegistry();
 const overridesRegistry = getOverridesRegistry();
+const queuedClient = getQueuedClientWrapper();
 
-const setupXHRInterceptor = (
-  queuedClient: ReturnType<typeof getQueuedClientWrapper>,
-): void => {
+const setupXHRInterceptor = (): void => {
   XHRInterceptor.disableInterception();
   XHRInterceptor.setSendCallback((data, request) =>
     setupRequestTracking(queuedClient, networkRequestsRegistry, data, request),
@@ -34,14 +33,14 @@ export type BootRecordingOptions = BootClientOptions;
  * Enable XHR interception early to capture boot-time requests.
  */
 const enableBootTimeInterception = (options?: BootRecordingOptions): void => {
-  const queuedClient = getQueuedClientWrapper(options);
+  queuedClient.setMaxQueueSize(options?.maxQueueSize ?? 200);
 
   if (queuedClient.isBootInterceptionEnabled()) {
     return;
   }
 
   queuedClient.enableBootInterception();
-  setupXHRInterceptor(queuedClient);
+  setupXHRInterceptor();
 };
 
 export const withOnBootNetworkActivityRecording = (

packages/network-activity-plugin/src/react-native/http/network-requests-registry.ts

@@ -12,18 +12,10 @@ export type NetworkRequestRegistry = {
 
 const REQUEST_TTL = 1000 * 60 * 5; // 5 minutes
 
-declare global {
-  var __rozeniteNetworkRequestsRegistry:
-    | Map<string, NetworkRegistryEntry>
-    | undefined;
-}
 
 export const getNetworkRequestsRegistry = (): NetworkRequestRegistry => {
-  if (!global.__rozeniteNetworkRequestsRegistry) {
-    global.__rozeniteNetworkRequestsRegistry = new Map();
-  }
-  const registry = global.__rozeniteNetworkRequestsRegistry;
-
+  const registry: Map<string, NetworkRegistryEntry> = new Map();
+  
   const trimRegistry = (): void => {
     const now = Date.now();
 

packages/network-activity-plugin/src/react-native/http/queued-client-wrapper.ts

@@ -88,16 +88,12 @@ export type BootClientOptions = {
   maxQueueSize?: number;
 };
 
+let instance: QueuedClientWrapper | null = null;
+
 export const getQueuedClientWrapper = (
-  options?: BootClientOptions,
 ): QueuedClientWrapper => {
-  if (!global.__rozeniteQueuedClientWrapper) {
-    global.__rozeniteQueuedClientWrapper = new QueuedClientWrapper();
-  }
-
-  if (options?.maxQueueSize !== undefined) {
-    global.__rozeniteQueuedClientWrapper.setMaxQueueSize(options.maxQueueSize);
+  if (!instance) {
+    instance = new QueuedClientWrapper();
   }
-
-  return global.__rozeniteQueuedClientWrapper;
+  return instance;
 };