-
-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error in macros/schema_tests/string_matching/* #125
Comments
Hi @samantha-guerriero-cko , thanks for raising that issue! You're right, I see the missing params. What's weird is that this passes our integration tests without an error. For example, this test gets called here. Also, let me know if you're interested in submitting a PR for this before I jump on this myself. |
Btw, I think the correct treatment here is probably to not support So, I'd set the {{ dbt_expectations.expression_is_true(model,
expression=expression,
group_by_columns=None,
row_condition=row_condition
)
}} |
It makes sense to make the group_by_columns=None :) For what concerns my environment:
I am happy to open a PR for this 💪 |
@samantha-guerriero-cko amazing, thank you! |
All the methods in macros/schema_tests/string_matching/ define a group_by_columns=group_by functionality, but group_by is not defined in the method which makes them fail with 'MacroGenerator' object is not iterable.
Fix should be to set up group_by=None in methods' definition as per the other macros with this functionality.
e.g.,
{% test expect_column_value_lengths_to_equal(model, column_name,
value,
group_by=None,
row_condition=None
) %}
The text was updated successfully, but these errors were encountered: