Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update description of type check tests #84

Merged
merged 1 commit into from
Jun 14, 2021

Conversation

noel
Copy link
Contributor

@noel noel commented Jun 14, 2021

Updated the descriptions for the column type check so it is more clear that they check the data type of the column, not the values within it.

@clausherther clausherther self-requested a review June 14, 2021 02:15
Copy link
Contributor

@clausherther clausherther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it, thanks @noel !

@clausherther clausherther merged commit b3b462a into calogica:main Jun 14, 2021
clausherther added a commit that referenced this pull request Jul 13, 2021
* Update project for dbt 0.20.0 compatibility

* First batch of test macro to test block conversions

* Shim dbt utils types macro

* Update test macros to tests

* Update description of type check tests (#84)

* Update changelog for new release (#86)

* Update README.md

* Remove unnecessary macro to fix issue with 0.19.2 (#88)

* Remove unnecessary macro to fix issue with 0.19.2

* Update changelog

* Fix value in set validation (#91)

* Add redshift to random macro

* Fix value in set validation

* Add integration test

* Fix missing space that was causing syntax error when compiled

* Move Redshift random() to separate PR

Co-authored-by: clausherther <claus@calogica.com>

* Add support for Redshift random function (#92)

* Update changelog for 0.3.7 (#93)

* Update project for dbt 0.20.0 compatibility

* First batch of test macro to test block conversions

* Shim dbt utils types macro

* Update test macros to tests

* Update CHANGELOG

* Bump dbt-date to 0.4.0+

Co-authored-by: Noel Gomez <noel_gomez@yahoo.com>
Co-authored-by: Ahmed Radwan <ahmedrad@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants