-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use NumericType classes, additional tests, transition to simplejson
.
#468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgyurgyik
changed the title
[WIP] Use NumericType classes, additional tests, transition to
Use NumericType classes, additional tests, transition to Mar 29, 2021
simplejson
.simplejson
.
rachitnigam
reviewed
Mar 29, 2021
rachitnigam
reviewed
Mar 29, 2021
Minor comments. Merge when addressed. I assume you've already tested the changes with calyx-eval? |
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #464. As discussed in there, The
json
module automatically converts decimal values tofloat
.simplejson
allows for the numbers to be casted directly to Decimal.Next, this PR adds a NumericType interface, which provide
FixedPoint
andBitnum
classes. Given a value (in decimal, binary string, or hexadecimal string form), width, and signed-ness, these classes will provide simple getter methods to view different interpretations of the variable, e.g.hex_string()
,unsigned_integer()
, and so on. Some simple checks are also implemented, such as overflow.will output: