Input field looses focus

[nikku]

Describe the bug

If I type in the Task Definition > Retries field the input looses focus. The same issue can be replicated across different types of FEEL (optional) fields.

Steps to reproduce

1. Write = some expression into a Task Definition > Retries field
2. Remove expression (all content)
3. Type = s again in the field
4. Input is no longer focussed

Expected behavior

Input keeps focus when field turns into an expression field

Environment

• OS: Linux
• Camunda Modeler Version: v5.28.0 (works in v5.27.0)
• Execution Platform: Camunda 8
• Installed plug-ins: None

Additional context

No response

[barmac]

I can reproduce it in v5.28 but cannot in v5.27.

[nikku]

I cannot reproduce this in the core libraries (bpmn-js-properties-panel main) either.

[barmac]

Let's check if we can reproduce it before the form-js update.

[barmac]

camunda-bpmn-js#main works fine

[barmac]

74bf225 is good (before form-js update)

[barmac]

This one is broken by 8f6662d too. So it's form-js update again.

[nikku]

I cannot reproduce this via core, so likely inconsistent code-mirror update.

[barmac]

This is more than just lost focus:

Screen.Recording.2024-09-26.at.14.20.09.mov

[barmac]

Right now I am puzzled. The bug is not present in the forms though (there's flickering but it's a different topic):

Screen.Recording.2024-09-26.at.14.25.12.mov

[barmac]

Current guess is that it's something about preact or diagram-js-ui.

[barmac]

So @bpmn-io/properties-panel ships with preact@10.19.3, and there is also preact@10.11.3 in node_modules.

[nikku]

Both are (should be) isolated from each other though.

[barmac]

Yes, and this does not change with the broken commit.

[barmac]

Any ideas?

[barmac]

Right now, the only solution I can see is to revert the update, and figure this out later.

[nikku]

Revert #4535 along with #4558 and see if this still works.

[barmac]

Let's try this.

[barmac]

LOL. I installed the outdated forms dependencies and pinned them, but that did not fix the problem :D

[barmac]

"Fix" coming via #4563

[nikku]

Closed via #4563.