From 4077b12aba33a014b8d8919f7019c0fb3b14c7fc Mon Sep 17 00:00:00 2001 From: Sergio Schvezov Date: Fri, 13 Dec 2024 12:41:38 -0300 Subject: [PATCH] fix: review fixes Co-authored-by: Imani Pelton --- tests/integration/test_messages_integration.py | 5 ++++- tests/unit/test_messages_emitter.py | 5 ++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/tests/integration/test_messages_integration.py b/tests/integration/test_messages_integration.py index dd30bdb..52f7d5f 100644 --- a/tests/integration/test_messages_integration.py +++ b/tests/integration/test_messages_integration.py @@ -908,7 +908,10 @@ def test_simple_errors_debugish(capsys, mode): @pytest.mark.parametrize("output_is_terminal", [True, False]) def test_error_api_details_quiet(capsys): - """Somewhat expected API error, final user modes.""" + """Somewhat expected API error, final user modes. + + Check that "quiet" is indeed quiet. + """ emit = Emitter() emit.init(EmitterMode.QUIET, "testapp", GREETING) full_error = {"message": "Invalid channel.", "code": "BAD-CHANNEL"} diff --git a/tests/unit/test_messages_emitter.py b/tests/unit/test_messages_emitter.py index b6551cf..427c2a6 100644 --- a/tests/unit/test_messages_emitter.py +++ b/tests/unit/test_messages_emitter.py @@ -878,7 +878,10 @@ def test_reporterror_simple_message_developer_modes(mode, get_initiated_emitter) def test_reporterror_detailed_info_quiet_modes(get_initiated_emitter): - """Report an error having detailed information, in final user modes.""" + """Report an error having detailed information, in final user modes. + + Check that "quiet" is indeed quiet. + """ emitter = get_initiated_emitter(EmitterMode.QUIET) error = CraftError("test message", details="boom") emitter.error(error)