Disable WatchList feature gate #4773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktsakalozos
reviewed
Dec 4, 2024
snap/hooks/configure
Outdated
| @@ -385,6 +385,13 @@ then | |||
| need_api_restart=true | |||
| fi | |||
|
|
|||
| # Disable the watchlist feature until k8s-dqlite can handle it | |||
| if ! grep -e "feature-gates=WatchList=false" ${SNAP_DATA}/args/kube-apiserver | |||
There was a problem hiding this comment.
is this enough? What if some one has set feature-gates=AnotherFeature=True,WatchList=false? Or what if someone has WatchList=true but is running etcd?
I think we should detect the absence of WatchList and make sure it is set to false.
There was a problem hiding this comment.
I've updated to append WatchList=false if it's absent.
ktsakalozos
reviewed
Dec 4, 2024
|
LGTM +1 thank you @berkayoz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable WatchList feature gate(enabled by default 1.32+) until k8s-dqlite can properly support it.