DPE-5493 Skip tls reconfiguration on unit teardown #522
Conversation
paulomach
requested review from
carlcsaposs-canonical,
shayancanonical and
taurus-forever
lib/charms/mysql/v0/tls.py
Outdated
| @@ -174,6 +174,9 @@ def _on_tls_relation_broken(self, _) -> None: | |||
| except KeyError: | |||
| # ignore key error for unit teardown | |||
| pass | |||
| if self.charm.removing_unit: | |||
There was a problem hiding this comment.
im wondering if it might be a good idea to add this check to all event handlers (or better yet, condition all self.framework.observe statements to ensure no event handlers run if charm is being removed)
to better understand: why are we allowing setting of secrets on lines 170-173 instead of just no-oping the handler entirely
There was a problem hiding this comment.
add this check to all event handlers
reconcile charm?
There was a problem hiding this comment.
yeah, eventually.
There was a problem hiding this comment.
to better understand: why are we allowing setting of secrets on lines 170-173 instead of just no-oping the handler entirely
indeed. If unit is going away, so will it's databag keys
lib/charms/mysql/v0/tls.py
Outdated
| @@ -174,6 +174,9 @@ def _on_tls_relation_broken(self, _) -> None: | |||
| except KeyError: | |||
| # ignore key error for unit teardown | |||
| pass | |||
| if self.charm.removing_unit: | |||
There was a problem hiding this comment.
add this check to all event handlers
reconcile charm?
Issue
Caught on tests, uncaught exception on unit teardown when related to a TLS operator
Solution
Skip TLS reconfiguration on unit teardown