Fix list of SANs and pg_rewind test #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marceloneppel
changed the title
marceloneppel
requested review from
Mehdi-Bendriss,
MiaAltieri,
averma-canonical,
delgod,
marcoppenheimer,
paulomach,
shayancanonical,
taurus-forever,
welpaolo and
zmraul
welpaolo
approved these changes
Oct 20, 2022
BON4
pushed a commit
to BON4/postgresql-k8s-operator
that referenced
this pull request
May 20, 2024
* Fix SANS and pg_rewind test * Improve code
github-actions bot
added a commit
to canonical/test-runners-2-github-x64-postgresql-k8s-operator
that referenced
this pull request
May 25, 2024
github-actions bot
added a commit
to canonical/test-runners-2-is-x64-postgresql-k8s-operator
that referenced
this pull request
May 26, 2024
github-actions bot
added a commit
to canonical/test-runners-2-azure-arm64-postgresql-k8s-operator
that referenced
this pull request
May 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Solution
Context
lib/charms/postgresql_k8s/v0/postgresql_tls.pyan additional missing SAN was added to match one more endpoint of the unit with the list provided by the certificate.Testing
tests/integration/test_tls.py(sometimes the replica promotion to primary doesn't happen and we need to request it again).Release Notes