Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uncaught promise errors don't throw? #589

Closed
protometa opened this issue Feb 6, 2017 · 2 comments
Closed

Uncaught promise errors don't throw? #589

protometa opened this issue Feb 6, 2017 · 2 comments
Labels
bug

Comments

@protometa
Copy link

protometa commented Feb 6, 2017 •
edited
Loading

This

_.fromError('err')
.done()

will throw uncaught error, whereas

_(Promise.reject('err'))
.done()

will not. Is this a bug?
@vqvu vqvu added the bug label Feb 7, 2017
@vqvu
Copy link
Collaborator

vqvu commented Feb 7, 2017

Yep. This is a bug. Fix in #591.

vqvu added a commit that referenced this issue Feb 7, 2017
@vqvu
Merge pull request #591 from vqvu/throw-uncaught-errors
8393ad6 
Make sure uncaught errors are correctly logged. Fixes #589.
@vqvu
Copy link
Collaborator

vqvu commented Feb 7, 2017

Should be fixed in v2.10.2.

@vqvu vqvu closed this as completed Feb 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@protometa @vqvu