Don't re-enter the consume callback (fixes #388). #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -429,6 +429,75 @@ exports['consume - fork after consume should not throw (issue #366)'] = function | |||
| } | |||
| } | |||
|
|
|||
| exports['race'] = { | |||
There was a problem hiding this comment.
Maybe put a reference to the PR number here?
|
I added the PR number to the inner test name. |
vqvu
force-pushed
the
consume-backpressure-fix
branch
from
0367027 to
c6729ff
Compare
vqvu
force-pushed
the
consume-backpressure-fix
branch
from
c6729ff to
d66ae44
Compare
|
LGTM. |
vqvu
added a commit
that referenced
this pull request
Nov 24, 2015
Don't re-enter the consume callback (fixes #388).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under certain circumstances, it was possible for the consume callback to be called while it was still executing. This can cause the source to be consumed even when there is backpressure. The result is that anything consumed while there is backpressure is thrown away.
More detailed explanation here: #388 (comment)