From c35c539506cdc6c4506eabb2d6ef5384c8b23354 Mon Sep 17 00:00:00 2001 From: Patrice Bender Date: Wed, 10 Apr 2024 15:10:24 +0200 Subject: [PATCH] fix: exclude `cds.LargeBinary` from wildcard expansion before this change, only the `MediaType` annotation was checked, but we should rather check the elements type as pointed out in [this comment](https://github.com/cap-js/cds-dbs/pull/570#pullrequestreview-1991546118) --- db-service/lib/cqn4sql.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/db-service/lib/cqn4sql.js b/db-service/lib/cqn4sql.js index c5d7bb0ca..293ce47e1 100644 --- a/db-service/lib/cqn4sql.js +++ b/db-service/lib/cqn4sql.js @@ -972,7 +972,7 @@ function cqn4sql(originalQuery, model) { const { index, tableAlias } = inferred.$combinedElements[k][0] const element = tableAlias.elements[k] // ignore FK for odata csn / ignore blobs from wildcard expansion - if (isManagedAssocInFlatMode(element) || (element['@Core.MediaType'] && !element['@Core.IsURL'])) return + if (isManagedAssocInFlatMode(element) || element.type === 'cds.LargeBinary') return // for wildcard on subquery in from, just reference the elements if (tableAlias.SELECT && !element.elements && !element.target) { wildcardColumns.push(index ? { ref: [index, k] } : { ref: [k] })