feat: fix type for extra volume mount (#418)

caraml-dev · May 23, 2024 · cb3e68c · cb3e68c
1 parent 6d54859
commit cb3e68c
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 8 deletions.
diff --git a/.github/config/ct.yaml b/.github/config/ct.yaml
@@ -1,6 +1,6 @@
 # See https://github.com/helm/chart-testing#configuration
 remote: origin
-target-branch: add-feast-ui-chart
+target-branch: main
 chart-dirs:
   - charts
 chart-repos:

diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml
@@ -83,7 +83,7 @@ jobs:
           fi
 
       - name: Run chart-testing (install)
-        run: ct install --config .github/config/ct.yaml --excluded-charts kserve,common --print-config
+        run: ct install --config .github/config/ct.yaml --excluded-charts kserve,common,feast-ui --print-config
 
       - name: Run chart-testing for kserve (install)
         env:

diff --git a/charts/feast-ui/Chart.yaml b/charts/feast-ui/Chart.yaml
@@ -1,7 +1,7 @@
 apiVersion: v1
 description: "Feast: ML Feature Store"
 name: feast-ui
-version: 0.5.0
+version: 0.5.1
 maintainers:
   - email: caraml-dev@caraml.dev
     name: caraml-dev
diff --git a/charts/feast-ui/README.md b/charts/feast-ui/README.md
@@ -1,6 +1,6 @@
 # feast-ui
 
-![Version: 0.5.0](https://img.shields.io/badge/Version-0.5.0-informational?style=flat-square)
+![Version: 0.5.1](https://img.shields.io/badge/Version-0.5.1-informational?style=flat-square)
 
 Feast: ML Feature Store
 
@@ -14,8 +14,8 @@ Feast: ML Feature Store
 
 | Key | Type | Default | Description |
 |-----|------|---------|-------------|
-| feast_ui.extraVolumeMounts | object | `{}` |  |
-| feast_ui.extraVolumes | object | `{}` |  |
+| feast_ui.extraVolumeMounts | list | `[]` |  |
+| feast_ui.extraVolumes | list | `[]` |  |
 | feast_ui.image.pullPolicy | string | `"IfNotPresent"` |  |
 | feast_ui.image.registry | string | `""` |  |
 | feast_ui.image.repository | string | `"feast-ui"` |  |

diff --git a/charts/feast-ui/values.yaml b/charts/feast-ui/values.yaml
@@ -12,9 +12,9 @@ feast_ui:
     internalPort: 8080
 
 
-  extraVolumes: {}
+  extraVolumes: []
 
-  extraVolumeMounts: {}
+  extraVolumeMounts: []
 
   livenessProbe:
     path: "/api/live"