From 6d9f602497e76427243bd120a37bffca5f2a534f Mon Sep 17 00:00:00 2001
From: conradennis <ctennis@us.ibm.com>
Date: Tue, 15 Nov 2022 10:18:11 -0500
Subject: [PATCH] feat(icons): renaming diamond status icon glyph (#12575)

* feat(icons): renaming diamond status icon glyph

Old version of the icon was named "undefined" which was conflicting with another icon in the repo.

Renaming to "diamond-fill" to match the convention of other status glyph names and resolve the naming conflict.

Updated categories.yml file with new icon name.
Approved by Carbon and Brand team

* added diamond-fill to icons.yml file

added diamond-fill to icons.yml file and removed glyph sizing from undefined.svg icon

* chore: update snapshots

Co-authored-by: Alison Joseph <alison.joseph@us.ibm.com>
Co-authored-by: TJ Egan <tw15egan@gmail.com>
Co-authored-by: Taylor Jones <tay1orjones@users.noreply.github.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
---
 .../__snapshots__/PublicAPI-test.js.snap          |  1 +
 .../__snapshots__/PublicAPI-test.js.snap          |  2 +-
 e2e/icons/__snapshots__/PublicAPI-test.js.snap    |  2 +-
 packages/icons/categories.yml                     | 15 ++++++++-------
 packages/icons/icons.yml                          |  9 ++++++++-
 .../src/svg/{undefined.svg => diamond-fill.svg}   |  0
 6 files changed, 19 insertions(+), 10 deletions(-)
 rename packages/icons/src/svg/{undefined.svg => diamond-fill.svg} (100%)

diff --git a/e2e/icons-react/__snapshots__/PublicAPI-test.js.snap b/e2e/icons-react/__snapshots__/PublicAPI-test.js.snap
index fad5ee404eb3..df2fc1e5a690 100644
--- a/e2e/icons-react/__snapshots__/PublicAPI-test.js.snap
+++ b/e2e/icons-react/__snapshots__/PublicAPI-test.js.snap
@@ -502,6 +502,7 @@ Array [
   "DewPointFilled",
   "Diagram",
   "DiagramReference",
+  "DiamondFill",
   "DirectLink",
   "DirectionBearRight_01",
   "DirectionBearRight_01Filled",
diff --git a/e2e/icons-vue/__snapshots__/PublicAPI-test.js.snap b/e2e/icons-vue/__snapshots__/PublicAPI-test.js.snap
index 08ba460ce045..2f3cf78059b8 100644
--- a/e2e/icons-vue/__snapshots__/PublicAPI-test.js.snap
+++ b/e2e/icons-vue/__snapshots__/PublicAPI-test.js.snap
@@ -1993,6 +1993,7 @@ Array [
   "DiagramReference20",
   "DiagramReference24",
   "DiagramReference32",
+  "DiamondFillGlyph",
   "DirectLink16",
   "DirectLink20",
   "DirectLink24",
@@ -6924,7 +6925,6 @@ Array [
   "UndefinedFilled20",
   "UndefinedFilled24",
   "UndefinedFilled32",
-  "UndefinedGlyph",
   "Undo16",
   "Undo20",
   "Undo24",
diff --git a/e2e/icons/__snapshots__/PublicAPI-test.js.snap b/e2e/icons/__snapshots__/PublicAPI-test.js.snap
index c14d62d9ad2e..11e054fb4e31 100644
--- a/e2e/icons/__snapshots__/PublicAPI-test.js.snap
+++ b/e2e/icons/__snapshots__/PublicAPI-test.js.snap
@@ -1992,6 +1992,7 @@ Array [
   "DiagramReference20",
   "DiagramReference24",
   "DiagramReference32",
+  "DiamondFillGlyph",
   "DirectLink16",
   "DirectLink20",
   "DirectLink24",
@@ -6923,7 +6924,6 @@ Array [
   "UndefinedFilled20",
   "UndefinedFilled24",
   "UndefinedFilled32",
-  "UndefinedGlyph",
   "Undo16",
   "Undo20",
   "Undo24",
diff --git a/packages/icons/categories.yml b/packages/icons/categories.yml
index 92fc398b2c48..9992517fb939 100644
--- a/packages/icons/categories.yml
+++ b/packages/icons/categories.yml
@@ -1316,6 +1316,8 @@ categories:
           - ZIP--reference
       - name: Status
         members:
+          - caution
+          - caution-inverted
           - checkmark
           - checkmark--filled
           - checkmark--filled--error
@@ -1323,19 +1325,17 @@ categories:
           - checkmark--outline
           - checkmark--outline--error
           - checkmark--outline--warning
+          - circle-fill
+          - circle-stroke
           - condition--point
           - condition--wait-point
+          - critical
+          - critical-severity
+          - diamond-fill
           - error
           - error--filled
           - error--outline
-          - caution
-          - caution-inverted
-          - circle-fill
-          - circle-stroke
-          - critical-severity
           - low-severity
-          - critical
-          - square-fill
           - help
           - help--filled
           - in-progress
@@ -1355,6 +1355,7 @@ categories:
           - pending
           - pending--filled
           - queued
+          - square-fill
           - undefined
           - undefined--filled
           - unknown
diff --git a/packages/icons/icons.yml b/packages/icons/icons.yml
index 85a35eaf0bc6..2a4750b3fa92 100644
--- a/packages/icons/icons.yml
+++ b/packages/icons/icons.yml
@@ -5855,6 +5855,14 @@
     - source
   sizes:
     - 32
+- name: diamond-fill
+  friendly_name: Diamond fill
+  aliases:
+    - diamond
+    - fill
+    - status
+  sizes:
+    - glyph
 - name: dicom--6000
   friendly_name: DICOM 6000
   sizes:
@@ -18463,7 +18471,6 @@
     - undefined
   sizes:
     - 32
-    - glyph
 - name: undefined--filled
   friendly_name: Undefined filled
   sizes:
diff --git a/packages/icons/src/svg/undefined.svg b/packages/icons/src/svg/diamond-fill.svg
similarity index 100%
rename from packages/icons/src/svg/undefined.svg
rename to packages/icons/src/svg/diamond-fill.svg