From 2ce57b31b3308fc8badb561ece4feaf612c2932f Mon Sep 17 00:00:00 2001 From: TJ Egan Date: Wed, 29 Jan 2020 09:55:59 -0800 Subject: [PATCH] fix(button): remove margin added by safari (#5169) * fix(button): remove margin added by safari * fix(button): add button fix to reset file as well * fix(button): make margin reset less browser specific --- packages/components/src/components/button/_mixins.scss | 2 ++ packages/components/src/globals/scss/_css--reset.scss | 5 +++++ 2 files changed, 7 insertions(+) diff --git a/packages/components/src/components/button/_mixins.scss b/packages/components/src/components/button/_mixins.scss index 020f645206cc..c97aea4c4cec 100644 --- a/packages/components/src/components/button/_mixins.scss +++ b/packages/components/src/components/button/_mixins.scss @@ -29,6 +29,8 @@ outline: none; position: relative; max-width: rem(320px); + // Fix to remove added margins on buttons in safari (see #5155) + margin: 0; &:disabled, &.#{$prefix}--btn--disabled { diff --git a/packages/components/src/globals/scss/_css--reset.scss b/packages/components/src/globals/scss/_css--reset.scss index d2e91732e7d3..8d60fd07128d 100644 --- a/packages/components/src/globals/scss/_css--reset.scss +++ b/packages/components/src/globals/scss/_css--reset.scss @@ -190,6 +190,11 @@ box-sizing: border-box; } + // Fix to remove added margins on buttons in safari (see #5155) + button { + margin: 0; + } + @include carbon--type-reset; @include carbon--icons; }