Return derivation path when answering `isOurs` #2219

KtorZ · 2020-10-06T18:26:23Z

Issue Number

Overview

6c3aaea
📍 change derivation path JSON serialization to be less verbose
And also aligned with other interfaces like cardano-addresses.
1bba794
📍 change 'isOurs' to return a derivation path instead of a boolean
This can then be used to figure out what are the derivation path of
a bunch of addresses when returning raw coin-selections.
Note that this commit builds but is so-to-speak unsound. We need to
find a way to feed the purpose, coin type and account index down to
the 'isOurs' function. The most logical place to do this is as part of
the state. We can't use arbitrary constant here because both Icarus
and Shelley use a SeqState, but have different purpose indexes.
4b116de
📍 store seq-state derivation prefix in the database.
That prefixes tells us which account corresponds to which state and also, which purpose so can distinguish between Icarus and Shelley wallets. This will require a database migration
which I'll add in a later commit.
185d8fb
📍 define manual migrations for seq-state with regards to the derivation prefix
I've generated databases for Icarus and Shelley wallets from the latest master and, in a test now trying to open these database and observe that a) it is possible, b) there's a log line indicating that a migration has happened, c) the resulting prefix in each database is exactly what we expect it to be.

Comments

KtorZ · 2020-10-06T18:29:27Z

lib/core/src/Cardano/Wallet/Primitive/AddressDerivation/Jormungandr.hs

+            purpose :: Index 'Hardened 'PurposeK
+            coinType :: Index 'Hardened 'CoinTypeK
+            accountIx :: Index 'Hardened 'AccountK
+            (purpose, coinType, accountIx) = undefined -- TODO: have this in the seq state


Whoops. Forgot to change that one. Will do.

KtorZ · 2020-10-06T18:29:38Z

lib/core/src/Cardano/Wallet/Primitive/AddressDerivation/Shelley.hs

+            purpose :: Index 'Hardened 'PurposeK
+            coinType :: Index 'Hardened 'CoinTypeK
+            accountIx :: Index 'Hardened 'AccountK
+            (purpose, coinType, accountIx) = undefined -- TODO: have this in the seq state


Whoops. Forgot to change that one. Will do.

KtorZ · 2020-10-06T18:31:31Z

lib/core/src/Cardano/Wallet/Primitive/AddressDiscovery/Sequential.hs

@@ -551,6 +555,8 @@ data SeqState (n :: NetworkDiscriminant) k = SeqState
        -- (cf: 'PendingIxs')
    , rewardAccountKey :: k 'AddressK XPub
        -- ^ Reward account public key associated with this wallet
+    , derivationPrefix :: DerivationPrefix
+        -- ^ Derivation path prefix from a root key up to the internal account


There are two major changes in this PR (which then ripples to many other files). One of them is here. DerivationPrefix is defined below and is simply a 3-tuple of the first three derivation indexes that leads to the account associated with that state.

This is necessary because we use seq-state for both Shelley and Icarus which have different purpose levels. Also, this will build a nice foundation for the up-coming multi-account support by having the actual account index within the state itself too!

KtorZ · 2020-10-06T18:32:14Z

lib/core/src/Cardano/Wallet/Primitive/AddressDiscovery/Sequential.hs

+                (_, Just addrIx) ->
+                    Just (purpose, coinType, accountIx, utxoInternal, addrIx)
+
+                _ -> Nothing


The other main change is here, in the definition of isOurs. Instead of returning a mere Bool, we now return the full derivation path corresponding to that address.

KtorZ · 2020-10-06T18:33:41Z

lib/core/src/Cardano/Wallet/Primitive/AddressDiscovery/Random.hs

    isOurs addr st =
-        (isJust path, maybe id (addDiscoveredAddress addr Used) path st)
+        (path, maybe id (addDiscoveredAddress addr Used) path st)


For random addresses, this is trivially achieved because decrypting the path is exactly how we identify whether a random address is ours or not.

KtorZ · 2020-10-06T18:33:58Z

lib/core/src/Cardano/Wallet/Primitive/AddressDiscovery/Sequential.hs

+                <*> fromText coinTypeT
+                <*> fromText accountT
+            _ ->
+                Left $ TextDecodingError "expected exactly 3 derivation paths"


TODO: add roundtrip tests to test these instances.

lib/core/src/Cardano/Wallet/DB/Sqlite/TH.hs

paweljakubas

Very fond of renaming initiative taken here - purposeCIP1852, coinTypeAda,.. all give more clarity. There is some more work to do (roundtrips, defined undefined, db migration support..etc) already mentioned. I wonder if some things (like purposeCI1852) should not be (some day in future) relocated further to cardano-addresses and imported here in cardano-wallet

KtorZ · 2020-10-07T12:15:03Z

I wonder if some things (like purposeCI1852) should not be (some day in future) relocated further to cardano-addresses and imported here in cardano-wallet

That's a good idea long-term indeed 👍

lib/core/src/Cardano/Wallet/Primitive/AddressDiscovery.hs

lib/core/src/Cardano/Wallet/Api/Types.hs

lib/core/src/Cardano/Wallet/DB/Sqlite/TH.hs

lib/core/src/Cardano/Wallet/Primitive/AddressDerivation.hs

lib/core/src/Cardano/Wallet/Primitive/AddressDiscovery/Sequential.hs

KtorZ · 2020-10-08T13:36:14Z

bors merge

2219: Return derivation path when answering `isOurs` r=KtorZ a=KtorZ # Issue Number  #2176 # Overview  - 6c3aaea 📍 **change derivation path JSON serialization to be less verbose** And also aligned with other interfaces like cardano-addresses. - 1bba794 📍 **change 'isOurs' to return a derivation path instead of a boolean** This can then be used to figure out what are the derivation path of a bunch of addresses when returning raw coin-selections. Note that this commit builds but is so-to-speak unsound. We need to find a way to feed the purpose, coin type and account index down to the 'isOurs' function. The most logical place to do this is as part of the state. We can't use arbitrary constant here because both Icarus and Shelley use a SeqState, but have different purpose indexes. - 4b116de 📍 **store seq-state derivation prefix in the database.** That prefixes tells us which account corresponds to which state and also, which purpose so can distinguish between Icarus and Shelley wallets. This will require a database migration which I'll add in a later commit. - 185d8fb 📍 **define manual migrations for seq-state with regards to the derivation prefix** I've generated databases for Icarus and Shelley wallets from the latest master and, in a test now trying to open these database and observe that a) it is possible, b) there's a log line indicating that a migration has happened, c) the resulting prefix in each database is exactly what we expect it to be. # Comments   Co-authored-by: KtorZ <matthias.benkort@gmail.com>

iohk-bors · 2020-10-08T13:52:02Z

Build failed:

buildkite/cardano-wallet


/build/cardano-wallet/lib/jormungandr/test/integration/Test/Integration/Jormungandr/Scenario/API/Transactions.hs:735:58: error:
--
  | • Couldn't match expected type ‘Cardano.Wallet.Primitive.AddressDerivation.Index
  | 'Cardano.Wallet.Primitive.AddressDerivation.Hardened
  | 'Cardano.Wallet.Primitive.AddressDerivation.PurposeK’
  | with actual type ‘Cardano.Wallet.Primitive.AddressDiscovery.Sequential.AddressPoolGap’
  | • In the third argument of ‘mkSeqStateFromRootXPrv’, namely
  | ‘defaultAddressPoolGap’
  | In the expression:
  | mkSeqStateFromRootXPrv @n (rootXPrv, pwd) defaultAddressPoolGap
  | In the expression:
  | (rootXPrv, pwd,
  | mkSeqStateFromRootXPrv @n (rootXPrv, pwd) defaultAddressPoolGap)
  | \|
  | 735 \|              , mkSeqStateFromRootXPrv @n (rootXPrv, pwd) defaultAddressPoolGap
  | \|                                                          ^^^^^^^^^^^^^^^^^^^^^

#expected

KtorZ · 2020-10-08T14:48:44Z

Damn.

hasufell · 2020-10-09T09:54:52Z

lib/core/src/Cardano/Wallet/Api/Types.hs

-data ApiAddressDerivationSegment = ApiAddressDerivationSegment
-    { derivationIndex :: !ApiRelativeAddressIndex
-    , derivationType :: !ApiAddressDerivationType
+data ApiDerivationSegment = ApiDerivationSegment


I want to use this data type in the Cardano.Wallet, which must not use API types. Because this is similar to

newtype Index (derivationType :: DerivationType) (level :: Depth) = Index { getIndex :: Word32 }

which I can't use as in a homogenous List easily. ApiAddressDerivationSegment would basically be non-typelevel version of Index.

Or... we could define a toText instance for Index

What about using the DerivationIndex from the Primitive.Types instead ?

That doesn't preserve the derivation type, don't we need that?

When considering all indexes as a list (or path):

the depth matters not because what the Depth captures is actually the position of the index in that list.

the derivationType is captured by representing indexes as plain Word32. The Soft / Hardened notation is for easing human-readability but in the end, a soft index is simply a value < 2^31, whereas a "hardened" index is simply a value >= 2^31. Therefore, instead of representing indexes as derivationType + relative index within 0 and 2^31, we can represent them as just an index between 0 and 2^32, which is what DerivationIndex does.

I should probably add these bits as comments.

iohk-bors · 2020-10-09T17:38:34Z

This PR was included in a batch that timed out, it will be automatically retried

2219: Return derivation path when answering `isOurs` r=KtorZ a=KtorZ # Issue Number  #2176 # Overview  - 6c3aaea 📍 **change derivation path JSON serialization to be less verbose** And also aligned with other interfaces like cardano-addresses. - 1bba794 📍 **change 'isOurs' to return a derivation path instead of a boolean** This can then be used to figure out what are the derivation path of a bunch of addresses when returning raw coin-selections. Note that this commit builds but is so-to-speak unsound. We need to find a way to feed the purpose, coin type and account index down to the 'isOurs' function. The most logical place to do this is as part of the state. We can't use arbitrary constant here because both Icarus and Shelley use a SeqState, but have different purpose indexes. - 4b116de 📍 **store seq-state derivation prefix in the database.** That prefixes tells us which account corresponds to which state and also, which purpose so can distinguish between Icarus and Shelley wallets. This will require a database migration which I'll add in a later commit. - 185d8fb 📍 **define manual migrations for seq-state with regards to the derivation prefix** I've generated databases for Icarus and Shelley wallets from the latest master and, in a test now trying to open these database and observe that a) it is possible, b) there's a log line indicating that a migration has happened, c) the resulting prefix in each database is exactly what we expect it to be. # Comments   Co-authored-by: KtorZ <matthias.benkort@gmail.com>

iohk-bors · 2020-10-09T20:18:35Z

Build failed:

buildkite/cardano-wallet

#2224

Failures:

  src/Test/Integration/Scenario/API/Shelley/StakePools.hs:659:9:
  1) API Specifications, SHELLEY_STAKE_POOLS, STAKE_POOLS_LIST_01 - List stake pools, has non-zero saturation & stake
       uncaught exception: IOException of type UserError
       user error (Waited longer than 90s (more than 2 epochs) for an action to resolve. Action: "list pools returns non-empty list". Error condition: Just user error (Quantity {getQuantity = Percentage {getPercentage = 0 % 1}} does not satisfy (> Quantity {getQuantity = Percentage {getPercentage = 0 % 1}})))

  To rerun use: --match "/API Specifications/SHELLEY_STAKE_POOLS/STAKE_POOLS_LIST_01 - List stake pools/has non-zero saturation & stake/"

Randomized with seed 1189452982

KtorZ · 2020-10-09T21:31:05Z

bors retry

2219: Return derivation path when answering `isOurs` r=KtorZ a=KtorZ # Issue Number  #2176 # Overview  - 6c3aaea 📍 **change derivation path JSON serialization to be less verbose** And also aligned with other interfaces like cardano-addresses. - 1bba794 📍 **change 'isOurs' to return a derivation path instead of a boolean** This can then be used to figure out what are the derivation path of a bunch of addresses when returning raw coin-selections. Note that this commit builds but is so-to-speak unsound. We need to find a way to feed the purpose, coin type and account index down to the 'isOurs' function. The most logical place to do this is as part of the state. We can't use arbitrary constant here because both Icarus and Shelley use a SeqState, but have different purpose indexes. - 4b116de 📍 **store seq-state derivation prefix in the database.** That prefixes tells us which account corresponds to which state and also, which purpose so can distinguish between Icarus and Shelley wallets. This will require a database migration which I'll add in a later commit. - 185d8fb 📍 **define manual migrations for seq-state with regards to the derivation prefix** I've generated databases for Icarus and Shelley wallets from the latest master and, in a test now trying to open these database and observe that a) it is possible, b) there's a log line indicating that a migration has happened, c) the resulting prefix in each database is exactly what we expect it to be. # Comments   Co-authored-by: KtorZ <matthias.benkort@gmail.com>

iohk-bors · 2020-10-10T00:06:40Z

Build failed:

ci/hydra-build:required

#2224

Failures:

  src/Test/Integration/Scenario/API/Shelley/StakePools.hs:659:9:
  1) API Specifications, SHELLEY_STAKE_POOLS, STAKE_POOLS_LIST_01 - List stake pools, has non-zero saturation & stake
       uncaught exception: IOException of type UserError
       user error (Waited longer than 90s (more than 2 epochs) for an action to resolve. Action: "list pools returns non-empty list". Error condition: Just user error (Quantity {getQuantity = Percentage {getPercentage = 0 % 1}} does not satisfy (> Quantity {getQuantity = Percentage {getPercentage = 0 % 1}})))

  To rerun use: --match "/API Specifications/SHELLEY_STAKE_POOLS/STAKE_POOLS_LIST_01 - List stake pools/has non-zero saturation & stake/"

Randomized with seed 1189452982

KtorZ · 2020-10-10T06:29:06Z

bors retry

2219: Return derivation path when answering `isOurs` r=KtorZ a=KtorZ # Issue Number  #2176 # Overview  - 6c3aaea 📍 **change derivation path JSON serialization to be less verbose** And also aligned with other interfaces like cardano-addresses. - 1bba794 📍 **change 'isOurs' to return a derivation path instead of a boolean** This can then be used to figure out what are the derivation path of a bunch of addresses when returning raw coin-selections. Note that this commit builds but is so-to-speak unsound. We need to find a way to feed the purpose, coin type and account index down to the 'isOurs' function. The most logical place to do this is as part of the state. We can't use arbitrary constant here because both Icarus and Shelley use a SeqState, but have different purpose indexes. - 4b116de 📍 **store seq-state derivation prefix in the database.** That prefixes tells us which account corresponds to which state and also, which purpose so can distinguish between Icarus and Shelley wallets. This will require a database migration which I'll add in a later commit. - 185d8fb 📍 **define manual migrations for seq-state with regards to the derivation prefix** I've generated databases for Icarus and Shelley wallets from the latest master and, in a test now trying to open these database and observe that a) it is possible, b) there's a log line indicating that a migration has happened, c) the resulting prefix in each database is exactly what we expect it to be. # Comments   Co-authored-by: KtorZ <matthias.benkort@gmail.com>

iohk-bors · 2020-10-10T08:30:02Z

Timed out.

#2224

Failures:

  src/Test/Integration/Scenario/API/Shelley/StakePools.hs:659:9:
  1) API Specifications, SHELLEY_STAKE_POOLS, STAKE_POOLS_LIST_01 - List stake pools, has non-zero saturation & stake
       uncaught exception: IOException of type UserError
       user error (Waited longer than 90s (more than 2 epochs) for an action to resolve. Action: "list pools returns non-empty list". Error condition: Just user error (Quantity {getQuantity = Percentage {getPercentage = 0 % 1}} does not satisfy (> Quantity {getQuantity = Percentage {getPercentage = 0 % 1}})))

  To rerun use: --match "/API Specifications/SHELLEY_STAKE_POOLS/STAKE_POOLS_LIST_01 - List stake pools/has non-zero saturation & stake/"

Randomized with seed 1189452982

And also aligned with other interfaces like cardano-addresses.

This can then be used to figure out what are the derivation path of a bunch of addresses when returning raw coin-selections. Note that this commit builds but is so-to-speak unsound. We need to find a way to feed the purpose, coin type and account index down to the 'isOurs' function. The most logical place to do this is as part of the state. We can't use arbitrary constant here because both Icarus and Shelley use a SeqState, but have different purpose indexes.

That prefixes tells us which account corresponds to which state and also, which purpose so can distinguish between Icarus and Shelley wallets. This will require a database migration which I'll add in a later commit.

… prefix I've generated databases for Icarus and Shelley wallets from the latest master and, in a test now trying to open these database and observe that a) it is possible, b) there's a log line indicating that a migration has happened, c) the resulting prefix in each database is exactly what we expect it to be.

…in resolved inputs.

…exes.

… already

Turns out that it is much easier and less error-prone to use a single opaque type 'DerivationIndex' to represent derivation path as homogeneous lists. Having 2 level of indirections in the API now makes thing more verbose and quite hard to grasp for a non-educated reader.

… about the derivation path.

KtorZ · 2020-10-10T10:08:57Z

bors merge

2219: Return derivation path when answering `isOurs` r=KtorZ a=KtorZ # Issue Number  #2176 # Overview  - 6c3aaea 📍 **change derivation path JSON serialization to be less verbose** And also aligned with other interfaces like cardano-addresses. - 1bba794 📍 **change 'isOurs' to return a derivation path instead of a boolean** This can then be used to figure out what are the derivation path of a bunch of addresses when returning raw coin-selections. Note that this commit builds but is so-to-speak unsound. We need to find a way to feed the purpose, coin type and account index down to the 'isOurs' function. The most logical place to do this is as part of the state. We can't use arbitrary constant here because both Icarus and Shelley use a SeqState, but have different purpose indexes. - 4b116de 📍 **store seq-state derivation prefix in the database.** That prefixes tells us which account corresponds to which state and also, which purpose so can distinguish between Icarus and Shelley wallets. This will require a database migration which I'll add in a later commit. - 185d8fb 📍 **define manual migrations for seq-state with regards to the derivation prefix** I've generated databases for Icarus and Shelley wallets from the latest master and, in a test now trying to open these database and observe that a) it is possible, b) there's a log line indicating that a migration has happened, c) the resulting prefix in each database is exactly what we expect it to be. # Comments   Co-authored-by: KtorZ <matthias.benkort@gmail.com>

iohk-bors · 2020-10-10T10:59:19Z

Build failed:

buildkite/cardano-wallet

#2233


Failures:
--
  |  
  | src/Test/Integration/Scenario/API/Shelley/Transactions.hs:949:5:
  | 1) API Specifications, SHELLEY_TRANSACTIONS, TRANS_EXTERNAL_02 - Multiple Outputs Transaction - Shelley witnesses
  | uncaught exception: IOException of type UserError
  | user error (Waited longer than 90s (more than 2 epochs) for an action to resolve. Action: "wFaucet and wSrc balances are as expected". Error condition: Just (HUnitFailure (Just (SrcLoc {srcLocPackage = "cardano-wallet-core-integration-2020.9.30-4HxhcWDVnZ34D20kVbXcRN", srcLocModule = "Test.Integration.Scenario.API.Shelley.Transactions", srcLocFile = "src/Test/Integration/Scenario/API/Shelley/Transactions.hs", srcLocStartLine = 1024, srcLocStartCol = 18, srcLocEndLine = 1024, srcLocEndCol = 67})) (ExpectedButGot Nothing "Quantity {getQuantity = 999989843200}" "Quantity {getQuantity = 999989843100}")))
  |  
  | To rerun use: --match "/API Specifications/SHELLEY_TRANSACTIONS/TRANS_EXTERNAL_02 - Multiple Outputs Transaction - Shelley witnesses/"
  |  
  | Randomized with seed 913803700

KtorZ · 2020-10-10T12:45:01Z

bors r+

iohk-bors · 2020-10-10T13:50:19Z

Build succeeded:

@KtorZ

2235: Fix extra-source-files not containing files used by TH r=hasufell a=hasufell 2239: WIP: Bump version from 2020.9.30 to 2020.10.13 r=KtorZ a=jonathanknowles  Compatible with [`jormungandr@v0.9.0`](https://github.com/input-output-hk/jormungandr/releases/tag/v0.9.0) and [`cardano-node@1.21.1`](https://github.com/input-output-hk/cardano-node/releases/tag/1.21.1). ## New Features - Adds the ability for users to select their own SMASH servers for stakepool listings. (#2214) - Adds transaction expiry slots for pending transactions. (#1879) ## Improvements - Adds a 100-wallet scenario to the latency benchmark. (#2223) - Adds an executable `shelley-test-cluster` which starts an integration test cluster that includes faucets. (#2178) - Extends `isOurs` to return the derivation path of an address. (#2219) ## Resolved Issues - Make pool garbage collection handle an unknown current epoch. (#2203) - Fixes incorrect mainnet network parameters returned from API. (#2226) ## Known Issues **_This section is a work in progress._** - Wallet restoration status reported incorrectly on mainnet. ([ADP-483](https://jira.iohk.io/browse/ADP-483)) ## Documentation  Cardano (cardano-node) | ITN (Jörmungandr) --- | --- [API Documentation](https://input-output-hk.github.io/cardano-wallet/api/v2020-10-13) | [API Documentation](https://input-output-hk.github.io/cardano-wallet/api/v2020-10-13) [CLI Manual](https://github.com/input-output-hk/cardano-wallet/wiki/Wallet-command-line-interface/f71ecb7ece3deaec5bf60f4a4beea1d3950e0d46) | [CLI Manual](https://github.com/input-output-hk/cardano-wallet/wiki/Wallet-command-line-interface-jormungandr/f71ecb7ece3deaec5bf60f4a4beea1d3950e0d46) [Docker Manual](https://github.com/input-output-hk/cardano-wallet/wiki/Docker/f71ecb7ece3deaec5bf60f4a4beea1d3950e0d46) | [Docker Manual](https://github.com/input-output-hk/cardano-wallet/wiki/Docker-jormungandr/f71ecb7ece3deaec5bf60f4a4beea1d3950e0d46) ## Installation Instructions ### Cardano (cardano-node) 1. Install [`cardano-node@1.21.1`](https://github.com/input-output-hk/cardano-node/releases/tag/1.21.1). 2. Download the provided `cardano-wallet` for your platform, and uncompress it in a directory that is on your `$PATH`, e.g. `/usr/local/bin`. Or `%PATH%` on Windows. 4. Start `cardano-wallet --help` and see available parameters. #### Docker Pull from DockerHub and verify the version matches 2020.10.13. ``` $ docker pull inputoutput/cardano-wallet:2020.10.13 $ docker run --rm inputoutput/cardano-wallet:2020.10.13 version ``` ### ITN (jormungandr) 1. Install [`jormungandr@v0.9.0`](https://github.com/input-output-hk/jormungandr/releases/tag/v0.9.0). 2. Download the provided `cardano-wallet-jormungandr` for your platform, and uncompress it in a directory that is on your `$PATH`, e.g. `/usr/local/bin`. Or `%PATH%` on Windows. 3. (optional) Install the bash/zsh auto-completion script according to the [jormungandr cli manual](https://github.com/input-output-hk/cardano-wallet/wiki/Wallet-Command-Line-Interface/{{JORM_CLI_WIKI_COMMIT}}) 4. Start `cardano-wallet --help` and see available parameters. #### Docker Pull from DockerHub and verify the version matches 2020.10.13 ``` $ docker pull inputoutput/cardano-wallet:2020.10.13-jormungandr $ docker run --rm inputoutput/cardano-wallet:2020.10.13-jormungandr version ``` ## Signatures  Name | Role | Approval --- | --- | ---: Matthias Benkort @KtorZ | Technical Team Lead | ⌛ Piotr Stachyra @piotr-iohk | QA Engineer | ⌛ Tatyana Valkevych @tatyanavych | Release Manager | ⌛ Co-authored-by: Julian Ospald <julian.ospald@iohk.io> Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io> Co-authored-by: Jonathan Knowles <jonathan.knowles@iohk.io> Co-authored-by: IOHK <devops+stack-project@iohk.io>

KtorZ added the ADDING FEATURE Mark a PR as adding a new feature, for auto-generated CHANGELOG label Oct 6, 2020

KtorZ requested a review from paweljakubas October 6, 2020 18:26

KtorZ self-assigned this Oct 6, 2020

KtorZ changed the base branch from master to KtorZ/2174/simplify-JSON-derivation-path October 6, 2020 18:26

KtorZ force-pushed the KtorZ/2176/derivation-path-in-addresses branch from 94942f9 to 7056362 Compare October 6, 2020 18:26

KtorZ force-pushed the KtorZ/2174/simplify-JSON-derivation-path branch from bc406dd to ac4222e Compare October 6, 2020 18:27

KtorZ force-pushed the KtorZ/2176/derivation-path-in-addresses branch from 7056362 to 2ef0111 Compare October 6, 2020 18:28

KtorZ commented Oct 6, 2020

View reviewed changes

lib/core/src/Cardano/Wallet/DB/Sqlite/TH.hs Show resolved Hide resolved

paweljakubas approved these changes Oct 7, 2020

View reviewed changes

KtorZ force-pushed the KtorZ/2176/derivation-path-in-addresses branch from 2ef0111 to 185d8fb Compare October 7, 2020 14:20

KtorZ changed the base branch from KtorZ/2174/simplify-JSON-derivation-path to master October 7, 2020 14:21

KtorZ force-pushed the KtorZ/2176/derivation-path-in-addresses branch from 185d8fb to e6aecc7 Compare October 7, 2020 15:16

hasufell reviewed Oct 8, 2020

View reviewed changes

KtorZ force-pushed the KtorZ/2176/derivation-path-in-addresses branch 2 times, most recently from 0888d02 to 7e4a6a4 Compare October 8, 2020 13:36

KtorZ mentioned this pull request Oct 8, 2020

change derivation path JSON serialization to be less verbose #2209

Closed

1 task

hasufell reviewed Oct 9, 2020

View reviewed changes

KtorZ force-pushed the KtorZ/2176/derivation-path-in-addresses branch 2 times, most recently from 648cab2 to 2755db9 Compare October 9, 2020 15:22

KtorZ added 10 commits October 10, 2020 12:08

change derivation path JSON serialization to be less verbose

fce8baa

And also aligned with other interfaces like cardano-addresses.

store seq-state derivation prefix in the database.

1a8cb1e

That prefixes tells us which account corresponds to which state and also, which purpose so can distinguish between Icarus and Shelley wallets. This will require a database migration which I'll add in a later commit.

add roundtrip test for ToText/FromText DerivationPrefix instances

9453a3a

adjust swagger documentation to reflect the presence derivation path …

76e28a2

…in resolved inputs.

change isOurs to return an homogenous list instead of n-tuples of ind…

cfbd4e7

…exes.

add '*.faulty.json' to gitignore, which we should've done a while ago…

67810df

… already

extend integration scenario about coin-selection with some assertions…

20e70b0

… about the derivation path.

KtorZ force-pushed the KtorZ/2176/derivation-path-in-addresses branch from 2755db9 to 20e70b0 Compare October 10, 2020 10:08

iohk-bors bot merged commit 364c480 into master Oct 10, 2020

iohk-bors bot deleted the KtorZ/2176/derivation-path-in-addresses branch October 10, 2020 13:50

KtorZ mentioned this pull request Oct 12, 2020

Provide a way to map addresses to their derivation paths. #2176

Closed

jonathanknowles mentioned this pull request Oct 13, 2020

Bump version from 2020.9.30 to 2020.10.13 #2239

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Return derivation path when answering `isOurs` #2219

Return derivation path when answering `isOurs` #2219

KtorZ commented Oct 6, 2020 •

edited

Loading

KtorZ Oct 6, 2020

KtorZ Oct 6, 2020

KtorZ Oct 6, 2020

KtorZ Oct 6, 2020

KtorZ Oct 6, 2020

KtorZ Oct 6, 2020

paweljakubas left a comment •

edited

Loading

KtorZ commented Oct 7, 2020

KtorZ commented Oct 8, 2020

iohk-bors bot commented Oct 8, 2020 •

edited by Anviking

Loading

KtorZ commented Oct 8, 2020

hasufell Oct 9, 2020

hasufell Oct 9, 2020

KtorZ Oct 9, 2020

hasufell Oct 9, 2020

KtorZ Oct 9, 2020

KtorZ Oct 9, 2020

iohk-bors bot commented Oct 9, 2020

iohk-bors bot commented Oct 9, 2020 •

edited by Anviking

Loading

KtorZ commented Oct 9, 2020

iohk-bors bot commented Oct 10, 2020 •

edited by Anviking

Loading

KtorZ commented Oct 10, 2020

iohk-bors bot commented Oct 10, 2020 •

edited by Anviking

Loading

KtorZ commented Oct 10, 2020

iohk-bors bot commented Oct 10, 2020 •

edited by Anviking

Loading

KtorZ commented Oct 10, 2020

iohk-bors bot commented Oct 10, 2020

Return derivation path when answering isOurs #2219

Return derivation path when answering isOurs #2219

Conversation

KtorZ commented Oct 6, 2020 • edited Loading

Issue Number

Overview

Comments

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

paweljakubas left a comment • edited Loading

Choose a reason for hiding this comment

KtorZ commented Oct 7, 2020

KtorZ commented Oct 8, 2020

iohk-bors bot commented Oct 8, 2020 • edited by Anviking Loading

KtorZ commented Oct 8, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

iohk-bors bot commented Oct 9, 2020

iohk-bors bot commented Oct 9, 2020 • edited by Anviking Loading

KtorZ commented Oct 9, 2020

iohk-bors bot commented Oct 10, 2020 • edited by Anviking Loading

KtorZ commented Oct 10, 2020

iohk-bors bot commented Oct 10, 2020 • edited by Anviking Loading

KtorZ commented Oct 10, 2020

iohk-bors bot commented Oct 10, 2020 • edited by Anviking Loading

KtorZ commented Oct 10, 2020

iohk-bors bot commented Oct 10, 2020

Return derivation path when answering `isOurs` #2219

Return derivation path when answering `isOurs` #2219

KtorZ commented Oct 6, 2020 •

edited

Loading

paweljakubas left a comment •

edited

Loading

iohk-bors bot commented Oct 8, 2020 •

edited by Anviking

Loading

iohk-bors bot commented Oct 9, 2020 •

edited by Anviking

Loading

iohk-bors bot commented Oct 10, 2020 •

edited by Anviking

Loading

iohk-bors bot commented Oct 10, 2020 •

edited by Anviking

Loading

iohk-bors bot commented Oct 10, 2020 •

edited by Anviking

Loading