Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crate maintenance has moved to Gitlab! #45

Open
Carter12s opened this issue May 2, 2022 · 16 comments
Open

Crate maintenance has moved to Gitlab! #45

Carter12s opened this issue May 2, 2022 · 16 comments

Comments

@Carter12s
Copy link

Carter12s commented May 2, 2022

Edit: May 2 2023

Maintenance of this crate has been picked up by lovoslavlovchev (with some help from me) @ https://gitlab.com/IovoslavIovchev/codegen

Please file new issues there. New versions of this crate on crates.io will be released from there.

---- Original Text:
This crate is useful, but missing some minor features. Several pull requests have been open for years without merging?

Would love not to fork, but actually to breath life into this crate?

@IovoslavIovchev
Copy link

I have forked this already since I needed some things (and plan to add more), don't mind merging here.

@Carter12s
Copy link
Author

@IovoslavIovchev It seems like there are potentially a few people interested in contributing.

I'd be interested in collaborating as a maintainer and working to get a codegen_v2 published on crates.io.

@frederikhors @theoparis @MicroJoe seem like they might also be interested.

Since you volunteered first, I'll start grabbing the relevant / useful MRs I'm tracking and raising them against your repo.

@IovoslavIovchev
Copy link

@Carter12s I actually haven't considered whether it's better to have my fork published as a new crate (as so far it has been fine to have it as a git dependency). Ideally, we could resurrect this project and maintain here, but I don't really mind it moving over to the fork and continuing the work there.

Before we do any of that, however, I wanna ping @carllerche to see what his plans for this project are. Should we proceed with the fork?

It goes without saying, if we were to move the project to my fork, anyone who might be interested is welcome to open issues and contribute.

@StephanvanSchaik
Copy link

I also have a project that is using this crate, so it would be nice to have a way forward since there are some subtle issues I noticed in the code generation + having useful traits for which I'd like to open some PRs. It looks like there is enough interest here in maintaining/improving the crate, which is nice :).

@neysofu
Copy link
Collaborator

neysofu commented Jun 19, 2022

I remember asking @carllerche a while back to see if he'd want to transfer ownership to anyone, but he basically told me that's not an option. Not sure if things are different now, but I think forking is the only viable option @IovoslavIovchev, so I suggest you go ahead and publish it under a different name.

@IovoslavIovchev
Copy link

A little update from me, I have been adding the changes I need, but I don't consider them worthy of a new version yet. Once I do, I will publish under the new name (I was thinking about codegen2 but it's already taken). If you check on crates.io, you can see a couple alternative names for this crate, both based on this code base. The two (there may be more) I have found:

  • rust-codegen, which currently has 2 commits, and you can clearly see it is this project's code from the LICENSE file. I don't see any other changes there.
  • codegen2, which has some changes but it's been stale for a while

@Carter12s
Copy link
Author

Carter12s commented Aug 13, 2022

Sorry for delay here @IovoslavIovchev

But I finally got around to updating my crate that depends on this.

I've opened a pile of issues with associated merge requests on your fork and collected what seem like the high value pull requests on this repo and mirrored them there.

Would love to get some of these merged down so we can release a new version of the crate under a new name, my reccomendation is codebuilder (there is a typosquat on code_builder but I still like the name).

I've also reached out to @andrewleverette who has previously published this crate to see if we can potentially get ownership of the original codegen on crates.io

@Carter12s
Copy link
Author

Good news!

I was able to get a hold of @andrewleverette and have been added as an owner of the crate on crates.io, so whenever myself and @IovoslavIovchev are able to get another release together will be able to publish it to the existing crate as 0.1.4 (or likely 0.2.0)

@IovoslavIovchev
Copy link

Awesome news, @Carter12s! Apologies for the delay, I am only now getting back to this project. I have started looking at the opened issues, and expect to have some MRs merged either tonight or tomorrow.

@ghost
Copy link

ghost commented Sep 14, 2022

This is such a useful crate. Would be great if an update could be done.

@Carter12s
Copy link
Author

v0.2.0 was sucessfully published with many of the pending updates over the last 2 years and is availible on crates.io

Development has moved over to https://gitlab.com/IovoslavIovchev/codegen as the primary active fork.

@Carter12s
Copy link
Author

I'm going to leave this issue open for people who find this repository and wonder where development is.

@sstubbs
Copy link

sstubbs commented Sep 21, 2022

This is such great news!

@hackaugusto
Copy link

Thanks for maintaining the crate! Maybe a comment could be added the original issue text? Unless someone reads the whole discussion it looks like the crate is unmaintained

@Carter12s Carter12s changed the title Is this crate unmaintained? Is a new maintainer needed? Crate maintenance has moved to Gitlab! May 2, 2023
@furkan-guvenc
Copy link

@Carter12s Can you add a warning to Readme so people can see the fork

@Carter12s
Copy link
Author

I actually can't... We got crates.io access to be able to publish new versions, but the reason maintenance moved to gitlab is none of current maintainers have access to this repo.

@Carter12s Carter12s reopened this Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants