-
-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
๐ต๏ธ for changes to enhance observability #725
Comments
Personally I prefer the generic approach, but the description is kinda... lacking? Could you propose a better name for it? |
@vhoyer - the best name is Description: "Improve observability", in line with "Improve accessibility" Here is some background on observability Here's an excerpt:
|
Donno, @carloscuesta @johannchopin , any thoughts? |
I like it since it can cover the analytic Gitmoji ๐ and also cover all other runtime debugging tool like sentry for example ๐ |
Does this really cover analytics? |
I don't see the use cases clear for this emoji, could you provide some examples? |
Hi @vhoyer, yes, it covers the collection of analytics. @carloscuesta - this covers:
Observability is your UI for servicing/operating your application. The emoji itself might be worth resisting - I want it to express "seeing inside" something. As a more generic concept, it is a superset that contains ๐ (๐?) ๐ฅ (if they are exposed) ๐ So quite a lot of this concept is not yet covered. |
You know what? I like it. Tho it could be hard to covey this idea merely by "observability" ๐ค albeit I have no better suggestion... |
Was just scrolling through the issues. +1 to the generic nature. Does "enhance insight" offer an alternative term? (From the thread, it seemed the term "observability" gave some pause, and I immediately thought "insight" when reading through.) |
@sylvanaar, if you want to hold out for a different emoji, X-Ray is a candidate for Unicode 14.0. It'll be a bit of a wait though. |
how about "improve code inspection"? @carloscuesta @johannchopin |
@vhoyer Yep I would agree on that ๐ |
Hey! The problem is see with this proposal is that we already have: Logs:
Healthchecks:
This one feels like grouping all of them into a bigger category, does it makes sense to add an emoji that covers all of the use-cases while maintaining those 3? ๐ค |
well, a lot of things are a grouping of the โจ and ๐ already, right? (in fact, it would be cool to see a visualization of this categories ahah) |
FWIW, since my original comment, I have seen and heard more references to the term observability. To provide another industry reference, I found a Google dev ops article on observability (and monitoring). Some more thoughts about choosing the gitmoji for commits following some recent work I have done. Overall, happy enough with the landscape, but feel that we could improve wording around this area. Plus, holding out for xray could have benefits (I find not using person emojis better).
|
Hey! Sounds good to me let's add this one ๐๐ผ |
Nice! Let me re-ask one of my questions hidden in my musings ๐ Do the speaker/sound gitmojis (๐ and ๐) refer explicitly to logs (and not metrics)? Or - no - they can also include metrics. |
I would say speaker/sound gitmojis only refer to logs! |
Thanks for clarifying! @sylvanaar - Do you have any new thoughts to add here? And thoughts on holding out for XRay emoji? (I really like using XRay as @meg-gutshall mentioned. And we should hopefully see it coming soon.) |
Not a big fan of introducing something that becomes a higher category for existing categories. The fact that this would cover both logs and metrics/tracing, which I already use the existing icons for, would just cause ambiguity IMHO. If there is some area of observability that is not covered today, I'd rather a specific icon be introduced for that instead of creating an "umbrella" icon that makes existing ones "obsolete". |
@jlandure - which emojis/icons do you use for metrics and/or tracing? My main interest was finding the best one for metrics, but tracing definitely relates. |
Regarding "observability as a higher category" - I am considering including an "observability" tag in #924 if we think observability does represent a higher grouping of existing emojis, and we would prefer a new, specific emoji. Tentatively, I have this list.
Thus, I think โmetricsโ is still missing, and I think we should have a dedicated emoji for it instead of trying to bind it to one of the existing ones. I will think about some emoji choices... (Note: I prefer not to use people emojis because of skin color configuration. For example, I use rocket to insert my emojis, so using Note: I originally included |
Oh, and on the subject of tracing. Does ๐ (Add or update analytics or track code) represent tracing? See #36 for original issue. If not, I think we hold out for ๐ฉป( |
My candidates for โAdd, update, or remove metrics,โ sorted alphabetically by short code.
|
ok, so, what is the definition of "tracing" and "metrics" we are working here? (because I always used ๐ and ๐ for "tracing" and ๐ for "metrics") |
Hello @carloscuesta ๐!
:detective:
This generalizes the Health Check (#668) proposal to mean any code that enhances the observability of the code. This includes instrumentation for debugging or adding metric sources, logs(covered?), and tracers.
Anything that helps you to find problems, and explores their root cause - but is not the main purpose of the rest of the application.
I liked the magnifier, and I pointed it to the right - but it is the same emoji as SEO. So I found this one.
The text was updated successfully, but these errors were encountered: