Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend theme to support lessons in Carpentries Incubator #1

Merged
merged 15 commits into from
Sep 25, 2019

Conversation

fmichonneau
Copy link
Contributor

No description provided.

The Carpentries Incubator</a>, a place to share and use each other's
Carpentries-style lessons. <strong>This lesson has not been reviewed by and is
not endorsed by The Carpentries</strong>.
</div>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ErinBecker please confirm that this wording is OK

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fmichonneau - this is good.

LICENSE.md Outdated
for official lessons to the relevant lesson program (i.e.,
<https://software-carpentry.org >, <https://datacarpentry.org>, or
<https://librarycarpentry.org>), provide a [link to the license][cc-by-human],
and indicate if changes were made. You may do so in any reasonable manner, but
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add missing paren after made.)

Copy link
Contributor

@ErinBecker ErinBecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! I'm making one small punctuation fix and then merging.

The Carpentries Incubator</a>, a place to share and use each other's
Carpentries-style lessons. <strong>This lesson has not been reviewed by and is
not endorsed by The Carpentries</strong>.
</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fmichonneau - this is good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants