Add jenkins 1.596

[jawshooah]

Jenkins installer for Mac.

The preflight, binary and postflight stanzas are certainly up for discussion. The intent is to provide a CLI equivalent to the one provided through brew install jenkins. I did something similar in #8279.

The pkg does install a script /Library/Application Support/Jenkins/jenkins-runner.sh, which the launchctl job calls, but it reads arguments from /Library/Preferences/org.jenkins-ci.plist rather than allowing the user to pass them in.

[jawshooah]

There's a problem; at the moment, zap fails if the cask has already been uninstalled because the uninstall script no longer exists. Not sure how to work around that.

Edit: This actually seems like a general problem with uninstaller scripts. Is there an issue around this already?

[vitorgalvao]

We’re don’t usually create those types of scripts. We shy away from them as much as possible, actually. If the one provided upstream is insufficient, that’s something we should solve there, as a cask installation should be as vanilla as possible (sometimes small tweaks are necessary because the process would be broken otherwise).

On another note, isn’t there a :pkgutil we could add to uninstall? :script is useful, but should always be used in addition to the other processes, not in replacement of.

zap fails if the cask has already been uninstalled because the uninstall script no longer exists.

Nice catch.

This actually seems like a general problem with uninstaller scripts. Is there an issue around this already?

I don’t think there is, but you’ve been finding a lot of broken stuff with the uninstall process, recently, so perhaps we should collect everything in a single issue.

[jawshooah]

We don’t usually create those types of scripts. We shy away from them as much as possible, actually.

Understood, I'll remove the jenkins.sh script. How about this, instead:

binary '/Library/Application Support/Jenkins/jenkins-runner.sh', :target => 'jenkins'

On another note, isn’t there a :pkgutil we could add to uninstall?

Yes, and also :launchctl. Before I discovered the uninstall script, I was using both. I'll add them in.

[vitorgalvao]

How about this, instead

Perfectly acceptable (last sentence).