Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include XML documentation in NuGet package #312

Closed
zalintyre opened this issue Oct 8, 2017 · 5 comments · Fixed by #313
Closed

Include XML documentation in NuGet package #312

zalintyre opened this issue Oct 8, 2017 · 5 comments · Fixed by #313
Milestone
v4.2.1

Comments

@zalintyre
Copy link

Caste.Core uses docblocks to document (public) methods. Why aren't they included in the latest NuGet package? I'm using version 4.2.0.
@stakx
Copy link
Member

stakx commented Oct 8, 2017

Good catch. Seems XML documentation was last included with version 4.0.0.

@ghost
Copy link

ghost commented Oct 8, 2017

Yep, would have been when I reworked the build process. Whoops!

#313

@zalintyre
Copy link
Author

Wow, that was really quick!

Thanks a lot!

@ghost ghost mentioned this issue Oct 8, 2017
Merged
@jonorossi
Copy link
Member

Thanks @Fir3pho3nixx, I've updated the changelog. We should get the same change into Windsor.

@jonorossi jonorossi added this to the vNext milestone Oct 9, 2017
@ghost
Copy link

ghost commented Oct 9, 2017

Ok, will do 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.2.1
Development

Successfully merging a pull request may close this issue.

Adding doc blocks back
3 participants
@stakx @jonorossi @zalintyre