-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DictionaryAdapter: Inconistency in NameValueCollection overload behind FEATURE_DICTIONARYADAPTER_XML #422
Comments
Makes sense, if the implementation can use Are you using DictionaryAdapter in your own projects? |
Thanks |
Changelog updated |
Glad that worked out so well. Just to answer your question. Yes, we only use the DictionaryAdapter part of Castle in our project. We are moving to netstandard 2.0 and after migrating a library suddenly the overloads were missing. Apparently, the netstandard 1.5 implementation was picked up. We solved that by multi-targeting to net461. I would be fantastic if there was netstandard 2.0 build, but i have read the discussion about it in another thread. Best, |
We'll have a .NET Standard 2.x build, but as you read in that other thread it can't be 2.0, but 2.1 should be possible. |
The
IDictionaryAdapterFactory
defines 2 overloads ofGetAdapter
that take aNameValueCollection
.In the interface the methods are behind the directive FEATURE_DICTIONARYADAPTER_XML IDictionaryAdapterFactory.cs#L64.
But the implementation shields only overloads that
XmlNode
DictionaryAdapterFactory.cs#L87.Since
System.Collections.Specialized
is already package reference, i think the 2 overloads could be exposed. Otherwise a new FEATURE_DICTIONARYADAPTER_NAMEVALUECOLLECTION could be introduced.I'm willing to contribute a PR.
The text was updated successfully, but these errors were encountered: