Fix DYNPROXY-186 .Net remoting (transparent proxy) cannot be proxied. #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…method Was throwing for this conditon (if (target != null && interfaceToProxy.IsInstanceOfType(target) == false)) at the beginning of the method. There was no need to do check this again. Also, this call interfaceToProxy.IsInstanceOfType(target) already validated that in the case of a transparent proxy, the target implement the interface. The call IsInstanceOfType is done on the real object (not the transparent proxy created by .net remoting). Kept the COM code there, but no idea if it's used by anyone since I did not find any issue/defect for lack of support of COM and it was not working since release 3.1.0 RC. TEST - Test done on an test application, hard to have a unit test for .net remoting issue. - Ran Unit Test
jcviau
referenced
this pull request
Apr 18, 2013
Support IChangeProxyTarget on additional interfaces and mixins when using CreateInterfaceProxyWithTargetInterface
Contributor
|
Hmmm, somehow Github doesn't want to show me the changes made in this commit, only the stats (which looks like pretty much every line in the file was changed in some way)... @jcviau any idea why? |
Contributor
Author
|
No idea, probably an issue with my GitHub settings. I will close this pull request, investigate this and do another one. |
Contributor
|
ok |
jonorossi
pushed a commit
that referenced
this pull request
May 23, 2017
Think I have net35 working using framework path override
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was throwing for this conditon (if (target != null &&
interfaceToProxy.IsInstanceOfType(target) == false)) at the beginning of
the method. There was no need to check this again.
Also, this call interfaceToProxy.IsInstanceOfType(target) already
validated that in the case of a transparent proxy, the target implement
the interface. The call IsInstanceOfType is done on the real object (not
the transparent proxy created by .net remoting).
Kept the COM code there, but no idea if it's used by anyone since I did
not find any issue/defect for lack of support of COM and it was not
working since release 3.1.0 RC.
TEST
remoting issue.