Support replication of attributes defined in AttributesToAlwaysReplicate list #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shoaibshakeel381
changed the title
shoaibshakeel381
changed the title
jonorossi
approved these changes
Sep 29, 2022
stakx
requested changes
Dec 11, 2022
There was a problem hiding this comment.
Sorry it took me so abysmally long to review this.
I'm in favor of this change, however there's one detail that might need adjusting before we merge... see review comment below.
P.S. could you please also add a new entry to CHANGELOG.md for this new feature?
# Castle Core Changelog
# Unreleased
Enhancements:
- ...
+- <Short description of the new feature goes here> (@shoaibshakeel381, #633)
## 5.1.1 (2022-12-30)
src/Castle.Core/DynamicProxy/Generators/AttributesToAlwaysReplicate.cs
Outdated
Show resolved
Hide resolved
Closed
added 3 commits
March 6, 2023 10:43
- This is complementary to AttributesToAvoidReplicating - This will allow consumers to specify attributes which should always be copied to generated proxy. It is especially useful where we do not own target interfeces and/or cannot override attributes, e.g. attributes used by various frameworks. This was mentioned in castleproject#593 - Similar effect could by achieved in Castle.Core Version 4.4.1 by simply extending various generator classes but in 5.0 all those classes were marked internal, without this fix we now have to override half the library, So this fix offers an alternative path. - Fixes castleproject#607
shoaibshakeel381
force-pushed
the
feature/alwaysreplicateattribute
branch
from
6787f3d to
af9a8ab
Compare
|
@stakx I have applied all requested changes. Please review |
stakx
approved these changes
Apr 9, 2023
|
Looks good to me! Thanks for your contribution @shoaibshakeel381, and sorry again for letting you wait so long. P.S. and sorry if I merged your commits too soon, perhaps I should have squashed them or let you do so first. Hope you don't mind too much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AttributesToAvoidReplicating