Add ability to parse raw text into docvectors on-the-fly for impact indexes #2122 #2148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lintool
reviewed
Jul 16, 2023
| return this.analyzer; | ||
| } | ||
|
|
||
| /** |
| cascade.add(new ScoreTiesAdjusterReranker()); | ||
| } | ||
|
|
||
| /** |
lintool
reviewed
Jul 18, 2023
| Query query = generator.buildQuery(Constants.CONTENTS, q); | ||
| String encodedQuery = encode_with_onnx(q); | ||
| public Result[] search(Map<String, Integer> encoded_q, int k) throws IOException, OrtException { | ||
| Map<String, Float> float_encoded_q = intToFloat(encoded_q); |
There was a problem hiding this comment.
I'm still not very happy with this... we get a Map<String, Integer>... and then we covert to Map<String, Float>... then it comes back as a flat String.
Should we be redesigning the QueryEncoder?
There was a problem hiding this comment.
just saw this. this line is not for query encoder thing, its for QueryGenerator to build query, which takes in float weight. so here I just convert Int to Float, for example 10 -> 10.0
…ap signature to compatible with python QueryEncoder until full integration
lintool
reviewed
Jul 27, 2023
| */ | ||
| public Result[] search(String q, int k) throws IOException, OrtException { | ||
| // make encoded query from raw query | ||
| Map<String, Integer> encoded_q = encode_with_onnx(q); |
lintool
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2122