Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional task to Initial Screening #295

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

1Basile
Copy link

@1Basile 1Basile commented Aug 4, 2022

No description provided.

@ronakice
Copy link
Member

ronakice commented Aug 4, 2022

Hey @1Basile thanks for the PR. By the way can you delete all the unnecessary files/file channges? As you can see your commit has changed over a hundred files.

1Basile added 2 commits August 4, 2022 22:50
Remove unnecessary build/ folder
@1Basile
Copy link
Author

1Basile commented Aug 5, 2022

Already done. Sorry for that, haven't seen.

@ronakice
Copy link
Member

Hey @1Basile it still seems like many useless files persist?

@1Basile
Copy link
Author

1Basile commented Sep 30, 2022 via email

@1Basile
Copy link
Author

1Basile commented Oct 2, 2022

I can not delete files, as they show the workflow.
I reduced the size of those files to 100k each, so it should not be that bad.

@ronakice
Copy link
Member

ronakice commented Oct 6, 2022

All these files are not required, they are just files you need during the reproduction, but we don't need your reproduction files in the repository. Just you signing off on the reproduction log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants