Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency in loading topics #516

Closed
jayparks opened this issue Apr 28, 2021 · 2 comments
Closed

Inconsistency in loading topics #516

jayparks opened this issue Apr 28, 2021 · 2 comments

Comments

@jayparks
Copy link

jayparks commented Apr 28, 2021

Currently, there is mismatch in topics loading across search/dsearch/hsearch.

In pyserini/search/__main__.py

topics = get_topics(args.topics)

In pyserini/dsearch/__main__.py and pyserini/hsearch/__main__.py

if os.path.exists(args.topics) and args.topics.endswith('.json'):
        topics = json.load(open(args.topics))
    else:
        topics = get_topics(args.topics)

It would be good to allow loading json topics for search to ensure consistency.

@MXueguang
Copy link
Member

Hi @jayparks,
Yes, we have a pending PR which will add this feature back. #405
We will merge it once we finish regression tests.

@MXueguang
Copy link
Member

Hi @jayparks.
#405 is merged.
It supports loading from json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants