We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Currently, there is mismatch in topics loading across search/dsearch/hsearch.
In pyserini/search/__main__.py
pyserini/search/__main__.py
topics = get_topics(args.topics)
In pyserini/dsearch/__main__.py and pyserini/hsearch/__main__.py
pyserini/dsearch/__main__.py
pyserini/hsearch/__main__.py
if os.path.exists(args.topics) and args.topics.endswith('.json'): topics = json.load(open(args.topics)) else: topics = get_topics(args.topics)
It would be good to allow loading json topics for search to ensure consistency.
search
The text was updated successfully, but these errors were encountered:
Hi @jayparks, Yes, we have a pending PR which will add this feature back. #405 We will merge it once we finish regression tests.
Sorry, something went wrong.
Hi @jayparks. #405 is merged. It supports loading from json.
No branches or pull requests
Currently, there is mismatch in topics loading across search/dsearch/hsearch.
In
pyserini/search/__main__.py
In
pyserini/dsearch/__main__.py
andpyserini/hsearch/__main__.py
It would be good to allow loading json topics for
search
to ensure consistency.The text was updated successfully, but these errors were encountered: