Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(content,mods/DinoMod): mountable flag audit and juvenile fixes #5621

Merged
merged 6 commits into from
Oct 28, 2024

Conversation

LyleSY
Copy link
Contributor

@LyleSY LyleSY commented Oct 28, 2024

Checklist

Required

Optional

Purpose of change

Bug workaround

Describe the solution

Removes mountable flag from any dino with 1000 kg assigned in code (generally means they are larger but the game physics can't model them yet). This prevents them throwing errors. After this only dinos that can be modeled pulling a wagon will be given that option.
Gives some smaller juvenile dinos the mountable flag they were missing
Also fixes some oddities in the juvenile JSON file that were previously missed, giving more appropriate size and weight and HP to a few small plant eaters.
Documents difference between PATH_AVOID_DANGER_1 in BN and PATH_AVOID_DANGER in DDA and the CAN_BE_CULLED flag. Reformats the doc some for readability

Describe alternatives you've considered

N/A

Testing

Works as intended, no errors

Additional context

This is the twin of CleverRaven/Cataclysm-DDA#77391
Thanks to proxiehunter on reddit for the idea to look at this https://www.reddit.com/r/cataclysmbn/comments/1gcr5mq/what_can_you_hook_up_to_a_yoke_and_harness/

@github-actions github-actions bot added JSON related to game datas in JSON format. mods PR changes related to mods. labels Oct 28, 2024
@chaosvolt
Copy link
Member

Hah you ninja'd my imminent change request review. I'll leave what I was gonna add regarding that here instead:

Slaughtering of tamed animals is automatically enabled by the monster being either a zombie (i.e. zombie zlaves) or in category WILDLIFE (i.e. where tameables that you'd expect to be cull-able would typically be). See associated PR: #4247

Dinos already use the WILDLIFE category extensively, so the only thing you should need for this to work is to just make sure the dinos you intended to add this to inherit from dinos that have that category assigned (if that still doesn't work then that would indicate an inheritance bug in the code). If an exception comes up that isn't covered by the code solution we didn't think of (like if someone mods in tameable mi-gos for example) we can add support for a monsterflag though.

@chaosvolt chaosvolt merged commit d882417 into cataclysmbnteam:main Oct 28, 2024
9 checks passed
@LyleSY LyleSY deleted the dinomod_ride_audit branch October 28, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format. mods PR changes related to mods.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants