Feature manager #37
Merged
Feature manager #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeteCoward
reviewed
Mar 22, 2023
There was a problem hiding this comment.
any reason for this pyi file given the py file has these types already?
There was a problem hiding this comment.
It's still necessary for mypy to pass on the Area model - this is probably because Area is not a regular Django model but an MPTTModel and I am guessing that the magic smoke and mirrors of MPTT prevents MyPy from being able to pick the types, as you can see if I delete the pyi we get test failures:
(simple-locations-8QRkAbfK-py3.8) josh@carbonite:~/github/catalpainternational/simple_locations$ rm simple_locations/models.pyi
(simple-locations-8QRkAbfK-py3.8) josh@carbonite:~/github/catalpainternational/simple_locations$ poetry run mypy .
simple_locations/models.py:66: error: Item "None" of "Optional[Field[Any, Any]]" has no attribute "db_column" [union-attr]
simple_locations/models.py:66: error: Item "None" of "Optional[Field[Any, Any]]" has no attribute "attname" [union-attr]
simple_locations/models.py:122: error: Need type annotation for "name" [var-annotated]
simple_locations/models.py:123: error: Need type annotation for "code" [var-annotated]
simple_locations/models.py:124: error: Need type annotation for "kind" [var-annotated]
simple_locations/models.py:125: error: Need type annotation for "location" [var-annotated]
simple_locations/models.py:127: error: Need type annotation for "parent" [var-annotated]
simple_locations/management/commands/import_dird.py:238: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs [annotation-unchecked]
tests/test_feature_manager.py:21: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs [annotation-unchecked]
tests/test_feature_manager.py:28: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs [annotation-unchecked]
tests/test_feature_manager.py:33: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs [annotation-unchecked]
tests/test_feature_manager.py:39: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs [annotation-unchecked]
|
This is now in DIRD@main: https://github.com/catalpainternational/openly_dird/pull/1890 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Django 3.2 introduced some really nice JSON functions
I'm working on this branch to make our geoJSON endpoints faster + more transparent for Openly DIRD and Partisipa's upcoming suco information 🎉