From 9512d49408d83d8ffb93285856b1096035891a87 Mon Sep 17 00:00:00 2001 From: Cody Baker <51133164+CodyCBakerPhD@users.noreply.github.com> Date: Thu, 13 Jun 2024 12:02:22 -0400 Subject: [PATCH 1/4] add test for packaging --- .github/workflows/run-tests.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 4c89b32c..8f08b47c 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -33,6 +33,11 @@ jobs: - name: Install roiextractors with minimal requirements run: pip install .[test] + - name: Test initial import of all non-lazy dependencies + run: python -c "import roiextractors" + + - name: Install roiextractors with testing requirements + run: pip install .[test] - name: Run minimal tests run: pytest tests/test_internals -n auto --dist loadscope From ec29b79259e0688558f8512048475578d90dc1f6 Mon Sep 17 00:00:00 2001 From: Cody Baker <51133164+CodyCBakerPhD@users.noreply.github.com> Date: Thu, 20 Jun 2024 15:51:53 -0400 Subject: [PATCH 2/4] properly adjust first minimal --- .github/workflows/run-tests.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 8f08b47c..08240bee 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -32,13 +32,12 @@ jobs: pip install wheel==0.41.2 # needed for scanimage - name: Install roiextractors with minimal requirements - run: pip install .[test] + run: pip install . - name: Test initial import of all non-lazy dependencies run: python -c "import roiextractors" - name: Install roiextractors with testing requirements run: pip install .[test] - - name: Run minimal tests run: pytest tests/test_internals -n auto --dist loadscope From 05de8a03879d5378169da516c271a932c0bb9b33 Mon Sep 17 00:00:00 2001 From: Cody Baker <51133164+CodyCBakerPhD@users.noreply.github.com> Date: Thu, 20 Jun 2024 16:11:47 -0400 Subject: [PATCH 3/4] add packaging to minimal --- requirements-minimal.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/requirements-minimal.txt b/requirements-minimal.txt index e210d142..6a8d39d7 100644 --- a/requirements-minimal.txt +++ b/requirements-minimal.txt @@ -7,3 +7,4 @@ scipy>=1.5.2 psutil>=5.8.0 PyYAML lxml +packaging From a300f4cbbfb0775bf825401bd0a0c7dfd69088e0 Mon Sep 17 00:00:00 2001 From: Cody Baker <51133164+CodyCBakerPhD@users.noreply.github.com> Date: Thu, 20 Jun 2024 16:16:48 -0400 Subject: [PATCH 4/4] Update CHANGELOG.md --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5455386e..8f95f9b3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -19,6 +19,7 @@ * Fixed the Daily testing workflows by passing along the appropriate secrets: [#340](https://github.com/catalystneuro/roiextractors/pull/340) * Change the criteria of determining if Bruker data is volumetric [#342](https://github.com/catalystneuro/roiextractors/pull/342) * Fixes a bug that assumes the channel name is is on the tiff file for `BrukerTiffSinglePlaneImagingExtractor` [#343](https://github.com/catalystneuro/roiextractors/pull/343) +* Including `packaging` explicitly in minimal requirements [#347](https://github.com/catalystneuro/roiextractors/pull/347) ### Improvements