Remove unnecessary semicolons #1173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reopening as the travis failure seems fishy. |
Codecov Report
@@ Coverage Diff @@
## master #1173 +/- ##
======================================
Coverage 81.6% 81.6%
======================================
Files 122 122
Lines 4697 4697
======================================
Hits 3833 3833
Misses 864 864 |
|
Thanks. I'll add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have a meson build that will build and run the Catch tests when Catch is used as a subproject. Those tests fail to build with the
-Wpedanticflag because of the extra semicolons removed by this PR. This is very minor, but I figured I'd go ahead and submit in case you want the changes.(Also, I don't know if you want to support a meson build in addition to CMake, but if that sounds appealing let me know and I will submit a PR.)
Thanks!