Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update nerdfont symbols #22

Merged
merged 3 commits into from
Jun 19, 2024
Merged

fix: update nerdfont symbols #22

merged 3 commits into from
Jun 19, 2024

Conversation

nonetrix
Copy link
Contributor

Successor to #17 fixes all the icons in one PR with https://github.com/loichyan/nerdfix#interactive-patching

@nonetrix
Copy link
Contributor Author

Can you review this @nekowinston @unseen-ninja @AlphaTechnolog sorry to ping just don't want a repeat of the last where it wasn't noticed really. PR should be no brainer to merge this

@sgoudham
Copy link

Hey 👋

Winston has left the organisation and I don't believe lemon (unseen-ninja) is active at the minute. I'm happy to merge but I feel like we should include somewhere in the README what version of nerdfonts these files are shipping with?

I haven't used nerdfonts in a while since my terminal fallbacks to a symbol font but I believe we can track the versions right?

@nonetrix
Copy link
Contributor Author

Ah sorry my bad, I didn't notice I just looked though few PRs and checked who they where merged by

@sgoudham
Copy link

No need to apologise! Just letting you know why people might not respond to that ping. I'm unsure if AlphaTechnolog is still active.

@nonetrix
Copy link
Contributor Author

nonetrix commented Jun 18, 2024

Newest version is v3.2.1 so I guess just go with that? Maybe something like

Requirements

  • A font patched with at least nerdfonts v3.2.1 or possibly higher, older versions untested
  • Rofi

Likely older versions work but I don't feel like testing them, should I add this to the README.md?

@nonetrix
Copy link
Contributor Author

nonetrix commented Jun 18, 2024

Another idea is to just setup a Github actions bot to just run nerdfix every so often, of course exclude any files that aren't .rasi just incase the weird edge case that somehow a image file for example happens to have bytes that look like nerdfont logo and just say to run newest release. I think that is over engineering though and I haven't played with actions, I doubt there is going to be a major codepoint shift in a while so it would be mostly in vain

Hint: This is over engineered

@sgoudham
Copy link

Happy to approve once the README is updated with the requirements as per your testing.
I think the action is overkill yeah

@nonetrix
Copy link
Contributor Author

Done

@nonetrix
Copy link
Contributor Author

Lemme see if I can somehow combine those commits so it doesn't clutter git log or whatever

@nonetrix
Copy link
Contributor Author

Eh whatever I can't figure it out doesn't matter, I think it might automatically do it anyway when merged? I only have basic idea of how PRs work

@sgoudham
Copy link

Don't worry about the git log 👍
I'll review and merge this PR when I'm free

@sgoudham sgoudham merged commit 9f0829b into catppuccin:main Jun 19, 2024
@sgoudham sgoudham changed the title fix: replace nerdfonts logos with updated ones fix: update nerdfont symbols Jun 19, 2024
This was referenced Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants