Test oms/child_order_quantity_computer/child_order_quantity_computer.py::get_range_filter

[samarth9008]

We want to test oms/child_order_quantity_computer/child_order_quantity_computer.py::get_range_filter

This function calls an abstract method which is implemented in the child classes.

https://github.com/kaizen-ai/kaizenflow/blob/c3ac308a1512e38ae29803dfde7223c367cb6a44/oms/child_order_quantity_computer/dynamic_scheduling_child_order_quantity_computer.py#L125

https://github.com/kaizen-ai/kaizenflow/blob/c3ac308a1512e38ae29803dfde7223c367cb6a44/oms/child_order_quantity_computer/static_scheduling_child_order_quantity_computer.py#L101

Implement the test accordingly for both the classes

See unit test doc to follow the code style
Also highly recommend to read this doc before submitting 1st PR

FYI @gpsaggese @sonaalKant @DanilYachmenev

[samarth9008]

Any updates @gurtajbir?

[samarth9008]

@gurtajbir Seems like you have other commitments. Not an issue. Re-routing it to @smitpatel49. Let us know when you are available to commit to the project.

FYI @DanilYachmenev

[smitpatel49]

I think I would need to create a new test file for it @samarth9008, or do I need to write it somewhere else specifically?

[samarth9008]

There are already tests written for this files

https://github.com/kaizen-ai/kaizenflow/tree/master/oms/limit_price_computer/test

Feel free to continue in them

[smitpatel49]

I am a bit confused, shouldn't the test cases for child_order_quantity_computer be in
https://github.com/kaizen-ai/kaizenflow/tree/master/oms/child_order_quantity_computer/test ?

[samarth9008]

Oh yeah my bad,

As per spec, You need to write tests in two different file. One is already created. Another you need to create.

[smitpatel49]

I think I can write the test for both static and dynamic classes in their respective test case classes.
(Edit: I will work on this tomorrow)

[samarth9008]

Sg, I see both the files have common test files. Ok to edit in the same file.

[smitpatel49]

@samarth9008 I am still occupied in a commitment, but I will complete this in a day or two.

[DanilYachmenev]

done