Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SorrTask1038_Test_get_range_filter #1066

Merged
merged 4 commits into from
Jul 5, 2024
Merged

SorrTask1038_Test_get_range_filter #1066

merged 4 commits into from
Jul 5, 2024

Conversation

smitpatel49
Copy link
Contributor

@smitpatel49 smitpatel49 added the PR_for_reviewers The PR needs to be reviewed by Team Leaders label Jun 27, 2024
@smitpatel49 smitpatel49 requested a review from sonaalKant June 27, 2024 16:32
@smitpatel49 smitpatel49 self-assigned this Jun 27, 2024
@smitpatel49
Copy link
Contributor Author

@samarth9008 , awaiting review on this one.

@smitpatel49 smitpatel49 requested a review from gpsaggese July 1, 2024 02:07
@DanilYachmenev DanilYachmenev added PR_for_authors The PR needs changes and removed PR_for_reviewers The PR needs to be reviewed by Team Leaders labels Jul 1, 2024
@smitpatel49 smitpatel49 added PR_for_reviewers The PR needs to be reviewed by Team Leaders and removed PR_for_authors The PR needs changes labels Jul 1, 2024
DanilYachmenev
DanilYachmenev reviewed Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@DanilYachmenev DanilYachmenev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DanilYachmenev DanilYachmenev added PR_for_integrators The PR needs to be reviewed and possibly merged and removed PR_for_reviewers The PR needs to be reviewed by Team Leaders labels Jul 2, 2024
gpsaggese
gpsaggese reviewed Jul 5, 2024
View reviewed changes
Copy link
Contributor

@gpsaggese gpsaggese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DanilYachmenev DanilYachmenev merged commit 8a4b383 into master Jul 5, 2024
1 check passed
@DanilYachmenev DanilYachmenev deleted the SorrTask1038_Test_get_range_filter branch July 5, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpsaggese gpsaggese gpsaggese left review comments

@DanilYachmenev DanilYachmenev DanilYachmenev approved these changes

@samarth9008 samarth9008 Awaiting requested review from samarth9008

@sonaalKant sonaalKant Awaiting requested review from sonaalKant

Assignees

@smitpatel49 smitpatel49

Labels
PR_for_integrators The PR needs to be reviewed and possibly merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smitpatel49 @DanilYachmenev @gpsaggese