Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unti test for dassert_is_valid_timestamp #1097

Merged

Conversation

jayati1397
Copy link
Contributor

@jayati1397 jayati1397 commented Jul 24, 2024

Created this PR for Issue #1094.

Changes Made:

  • Implemented unit tests for dassert_is_valid_timestamp

Testing:
Ran code through pylint and pytest.

  • Pylint Errors: Class name: currently follows the convention specified here.
OUTPUT from the added lines in the file
helpers/test/test_hdatetime.py:781:0: C0115: Missing class docstring (missing-class-docstring)
helpers/test/test_hdatetime.py:781:0: C0103: Class name "Test_dassert_is_valid_timestamp" doesn't conform to PascalCase naming style (invalid-name)
  • Pytest: No errors.
OUTPUT:
collected 3 items      
                                                                                                                                 
helpers/test/test_hdatetime.py::Test_dassert_is_valid_timestamp::test1 (0.00 s) PASSED [ 33%]
helpers/test/test_hdatetime.py::Test_dassert_is_valid_timestamp::test2 (0.00 s) PASSED [ 66%]
helpers/test/test_hdatetime.py::Test_dassert_is_valid_timestamp::test3 (0.00 s) PASSED [100%]

@samarth9008 please let me know if you have any further suggestions

@jayati1397 jayati1397 requested a review from samarth9008 July 24, 2024 18:46
@jayati1397 jayati1397 marked this pull request as ready for review July 24, 2024 18:46
Copy link
Collaborator

@samarth9008 samarth9008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nits from my side

helpers/test/test_hdatetime.py Outdated Show resolved Hide resolved
helpers/test/test_hdatetime.py Outdated Show resolved Hide resolved
helpers/test/test_hdatetime.py Outdated Show resolved Hide resolved
helpers/test/test_hdatetime.py Outdated Show resolved Hide resolved
helpers/test/test_hdatetime.py Outdated Show resolved Hide resolved
helpers/test/test_hdatetime.py Outdated Show resolved Hide resolved
@jayati1397 jayati1397 requested a review from samarth9008 July 24, 2024 22:06
Copy link
Collaborator

@samarth9008 samarth9008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final nits.

helpers/test/test_hdatetime.py Show resolved Hide resolved
helpers/test/test_hdatetime.py Outdated Show resolved Hide resolved
helpers/test/test_hdatetime.py Outdated Show resolved Hide resolved
helpers/test/test_hdatetime.py Outdated Show resolved Hide resolved
@jayati1397 jayati1397 self-assigned this Jul 29, 2024
@jayati1397 jayati1397 requested a review from samarth9008 July 29, 2024 13:30
@samarth9008
Copy link
Collaborator

@jayati1397 Can you resolve conflicts on this PR and then its a merge?

@jayati1397
Copy link
Contributor Author

@jayati1397 Can you resolve conflicts on this PR and then its a merge?

Done!

Copy link
Collaborator

@samarth9008 samarth9008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samarth9008 samarth9008 merged commit 423470c into master Jul 31, 2024
1 check passed
@samarth9008 samarth9008 deleted the KaizenTask1094_unit_test_dassert_is_valid_timestamp branch July 31, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants