-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unti test for dassert_is_valid_timestamp #1097
unti test for dassert_is_valid_timestamp #1097
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few nits from my side
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final nits.
@jayati1397 Can you resolve conflicts on this PR and then its a merge? |
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Created this PR for Issue #1094.
Changes Made:
dassert_is_valid_timestamp
Testing:
Ran code through pylint and pytest.
@samarth9008 please let me know if you have any further suggestions