-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix few VM issues within Quick_start_for_developing.md #463
Conversation
@aaryapatel100 what issue is this related to btw? if so, pls put a reference to it in the PR desc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although, I have reviewed but lets wait for @DanilYachmenev comment before implementing any changes.
honestly, I'm a bit out of context here |
Yeah, so these were all issues/errors that I encountered in the onboarding process in which I thought the steps might be better clarified in the documentation. Important to note, that these did come up within VMWare usage so not sure if errors will replicate for all but in the case that they do easy things to look out for. The aws-cli installation error during thin environment build is probably the most notable one as it just crashed the terminal in less than a second of outputting error and seems to be a much larger issue with this specific package dependency. I figured that adding a note about terminal crashing would be useful for 2 reasons: a) saves time for onboarder from having to screen record build process and see what happened and b) given the speed of crash, someone might figure it's not necessarily an error, open terminal, run the activation command, and deal with a whole host of other issues. |
ok then implement the comments that Samarth has left and we can ask for GP to take a look |
Ok, comments have been implemented. @gpsaggese Could you please take a look to the updated quick-start documentation? |
Closing as not planned. |
No description provided.