-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SorrTask762_start_downloading_data #771
Conversation
Good start, Lets get some example data points from each API and log them in some doc so that we quickly see and analyse the next steps. |
research_llm/data_download.py
Outdated
# ## goperigon.com pipeline | ||
|
||
# %% | ||
class goperigonPipeline: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for OOPs programming inside notebooks. Over here, you can try interacting with API directly. Download the data and get a sense about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But lets follow what @sonaalKant says. This is just my opinion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My take is to do whatever is faster. This is exploration. We want a dataframe with data to look at
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kept the OOP method because I feel like this way gives us more functionality through controlling attributes of class instances. This could come quite handy while extracting data with different params/endpoints, making it faster, IMO. Let me know if this is okay.
@gpsaggese @sonaalKant @samarth9008 We can interpret this as different |
@sonaalKant @gpsaggese
I have developed an initial version of the code to download data from the specified sources mention in #762. However, we have a few bottlenecks with the free API:
version requires payment info.
blocked. Example, crypto.
Review: