SorrTask-782 Unit tests for calculate_vwap_twap() #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gpsaggese Please review the skeleton. |
|
The skeleton looks good. Feel free to move forward with testing. |
|
sure. Thanks for the update. |
|
I wanted to understand the data being tested in the calculate_vwap function. I found the volume column but couldn’t find a price column. Also observing the code, led me to a resampling rule value of “5T” and just wanted to confirm if I’m on the right track for the resampling rule or is it something else? |
added 2 commits
April 23, 2024 14:01
Added both unit tests with different resample rules. Test case passing successfully. |
|
Linter run is still pending. |
|
Also, pls use PR labels so reviewers can react on your PR in time |
aish-nidhi
added
PR_for_reviewers
|
Passed tests post changes.
|
DanilYachmenev
added
PR_for_authors
aish-nidhi
added
PR_for_reviewers
aish-nidhi
changed the title
added 2 commits
April 29, 2024 12:58
…://github.com/kaizen-ai/kaizenflow into SorrTask782_Unit_test_calculate_vwap_function
DanilYachmenev
added
PR_for_authors
aish-nidhi
added
PR_for_reviewers
DanilYachmenev
added
PR_for_integrators
Kev-Daran
pushed a commit
to Kev-Daran/kaizenflow
that referenced
this pull request
May 8, 2024
* Issue causify-ai#782 draft PR with code skeleton * Issue causify-ai#782 unit tests for function calculate_vwap_twap with 2 different resampling rules * Fix for ambiguous truth value of multiindex column names * Linter corrections on file * Changes for PR comment * Modifications to address PR comments * Adding full-stop to comments --------- Co-authored-by: Aishwarya Nidhi <aishwaryanidhi@Aishwaryas-Air.cgocable.net> Co-authored-by: Samarth KaPatel <samarth.kapatel5@gmail.com>
DIPOLAWSON
pushed a commit
that referenced
this pull request
May 9, 2024
* Issue #782 draft PR with code skeleton * Issue #782 unit tests for function calculate_vwap_twap with 2 different resampling rules * Fix for ambiguous truth value of multiindex column names * Linter corrections on file * Changes for PR comment * Modifications to address PR comments * Adding full-stop to comments --------- Co-authored-by: Aishwarya Nidhi <aishwaryanidhi@Aishwaryas-Air.cgocable.net> Co-authored-by: Samarth KaPatel <samarth.kapatel5@gmail.com>
Nadiyahlw
added a commit
that referenced
this pull request
May 9, 2024
* Revert "Add DATA605 directory (#876)" (#884) This reverts commit 00e90d2. * SorrTask786 Unit test for split_positive_and_negative_parts() (#883) * Added Unit test for split_positive_and_negative_parts() * Resolved comments * Added remaining comments * deleted unnecessary files * "Fixes" * Comment resolution * Comments resolved. --------- Co-authored-by: Samarth KaPatel <samarth.kapatel5@gmail.com> * SorrTask-782 Unit tests for calculate_vwap_twap() (#801) * Issue #782 draft PR with code skeleton * Issue #782 unit tests for function calculate_vwap_twap with 2 different resampling rules * Fix for ambiguous truth value of multiindex column names * Linter corrections on file * Changes for PR comment * Modifications to address PR comments * Adding full-stop to comments --------- Co-authored-by: Aishwarya Nidhi <aishwaryanidhi@Aishwaryas-Air.cgocable.net> Co-authored-by: Samarth KaPatel <samarth.kapatel5@gmail.com> * SorrTask-891 Unit tests for compute epoch function (#901) * Issue 891 - Unit test code skeleton * Issue-891 3 unit tests with each available unit value for Series input. * Issue-891 Unit test of compute epoch function for dataframe input with default unit * Adding missed full stop for comment * PR comment fixes * Removing todo from function * PR comment fixes --------- Co-authored-by: Aishwarya Nidhi <aishwaryanidhi@Aishwaryas-Air.cgocable.net> Co-authored-by: Samarth KaPatel <samarth.kapatel5@gmail.com> * SorTask903 Unit test convert_seconds_to_pandas_minutes() (#907) * Added unit test for function convert_seconds_to_minutes * Nits --------- Co-authored-by: Shaunak Dhande <77265046+Shaunak01@users.noreply.github.com> Co-authored-by: neha2801-create <77967216+neha2801-create@users.noreply.github.com> Co-authored-by: Samarth KaPatel <samarth.kapatel5@gmail.com> Co-authored-by: Aishwarya Nidhi <nidhiaishwarya8@gmail.com> Co-authored-by: Aishwarya Nidhi <aishwaryanidhi@Aishwaryas-Air.cgocable.net>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a draft PR to illustrate the code skeleton.