Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SorrTask904 Unit test find_min_max_timestamps_from_intervals() #911

Merged
merged 6 commits into from
May 10, 2024
Merged

SorrTask904 Unit test find_min_max_timestamps_from_intervals() #911

merged 6 commits into from
May 10, 2024

Conversation

neha2801-create
Copy link
Collaborator

#904

  • Added Unit tests for method find_min_max_timestamps_from_intervals()

@neha2801-create neha2801-create added the PR_for_reviewers The PR needs to be reviewed by Team Leaders label May 5, 2024
@neha2801-create neha2801-create linked an issue May 5, 2024 that may be closed by this pull request
Unit test find_min_max_timestamps_from_intervals() #904
Closed
DanilYachmenev
DanilYachmenev reviewed May 6, 2024
View reviewed changes
Copy link
Collaborator

@DanilYachmenev DanilYachmenev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good coverage but needs to be restructured first

dataflow/core/test/test_utils.py Outdated Show resolved Hide resolved
dataflow/core/test/test_utils.py Outdated Show resolved Hide resolved
dataflow/core/test/test_utils.py Outdated Show resolved Hide resolved
@DanilYachmenev DanilYachmenev added PR_for_authors The PR needs changes and removed PR_for_reviewers The PR needs to be reviewed by Team Leaders labels May 6, 2024
@neha2801-create neha2801-create added PR_for_reviewers The PR needs to be reviewed by Team Leaders and removed PR_for_authors The PR needs changes labels May 7, 2024
@DanilYachmenev DanilYachmenev added PR_for_authors The PR needs changes and removed PR_for_reviewers The PR needs to be reviewed by Team Leaders labels May 7, 2024
@neha2801-create neha2801-create added PR_for_reviewers The PR needs to be reviewed by Team Leaders and removed PR_for_authors The PR needs changes labels May 7, 2024
DanilYachmenev
DanilYachmenev reviewed May 7, 2024
View reviewed changes
dataflow/core/test/test_utils.py Outdated Show resolved Hide resolved
dataflow/core/test/test_utils.py Outdated Show resolved Hide resolved
dataflow/core/test/test_utils.py Outdated Show resolved Hide resolved
dataflow/core/test/test_utils.py Outdated Show resolved Hide resolved
dataflow/core/test/test_utils.py Outdated Show resolved Hide resolved
dataflow/core/test/test_utils.py Outdated Show resolved Hide resolved
dataflow/core/test/test_utils.py Outdated Show resolved Hide resolved
dataflow/core/test/test_utils.py Outdated Show resolved Hide resolved
dataflow/core/test/test_utils.py Outdated Show resolved Hide resolved
dataflow/core/test/test_utils.py Outdated Show resolved Hide resolved
@DanilYachmenev DanilYachmenev added PR_for_authors The PR needs changes and removed PR_for_reviewers The PR needs to be reviewed by Team Leaders labels May 7, 2024
@neha2801-create
Fixes
ea55e59
@neha2801-create
Merge branch 'SorrTask904_unit_test_find_min_max_timestamps_from_inte…
b93488c 
…rvals' of github.com:kaizen-ai/kaizenflow into SorrTask904_unit_test_find_min_max_timestamps_from_intervals
@neha2801-create neha2801-create added PR_for_reviewers The PR needs to be reviewed by Team Leaders and removed PR_for_authors The PR needs changes labels May 9, 2024
DanilYachmenev
DanilYachmenev reviewed May 9, 2024
View reviewed changes
dataflow/core/test/test_utils.py Outdated Show resolved Hide resolved
dataflow/core/test/test_utils.py Outdated Show resolved Hide resolved
dataflow/core/test/test_utils.py Outdated Show resolved Hide resolved
dataflow/core/test/test_utils.py Outdated Show resolved Hide resolved
@DanilYachmenev DanilYachmenev added PR_for_authors The PR needs changes and removed PR_for_reviewers The PR needs to be reviewed by Team Leaders labels May 9, 2024
@neha2801-create neha2801-create added PR_for_reviewers The PR needs to be reviewed by Team Leaders and removed PR_for_authors The PR needs changes labels May 9, 2024
DanilYachmenev
DanilYachmenev reviewed May 9, 2024
View reviewed changes
Copy link
Collaborator

@DanilYachmenev DanilYachmenev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
fyi @samarth9008

@DanilYachmenev DanilYachmenev added PR_for_integrators The PR needs to be reviewed and possibly merged and removed PR_for_reviewers The PR needs to be reviewed by Team Leaders labels May 9, 2024
samarth9008
samarth9008 approved these changes May 10, 2024
View reviewed changes
Copy link
Collaborator

@samarth9008 samarth9008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samarth9008 samarth9008 merged commit 08ff1fa into master May 10, 2024
1 check passed
@samarth9008 samarth9008 deleted the SorrTask904_unit_test_find_min_max_timestamps_from_intervals branch May 10, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanilYachmenev DanilYachmenev DanilYachmenev left review comments

@samarth9008 samarth9008 samarth9008 approved these changes

Assignees

@neha2801-create neha2801-create

Labels
PR_for_integrators The PR needs to be reviewed and possibly merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unit test find_min_max_timestamps_from_intervals()
3 participants
@neha2801-create @DanilYachmenev @samarth9008