Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show face tags in photo modal #3

Open
cbenning opened this issue May 14, 2020 · 1 comment
Open

Show face tags in photo modal #3

cbenning opened this issue May 14, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@cbenning
Copy link
Owner

Want to see the face tags in the image modal.
@cbenning cbenning added the enhancement New feature or request label May 14, 2020
@cbenning
Copy link
Owner Author

I tried a bunch of tricks here, and its definitely possible. The problem I've been having is with the actual carousel inside react-images, as the callbacks seem inconsistent and the timing is bad enough I cannot grab the current displayed image from the dom reliably.

There is a ticket in react-images to update it's implementation to a different library so I might wait for that to pan out before I waste more time on this.

@cbenning cbenning mentioned this issue Sep 15, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cbenning